Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756931Ab0FIMft (ORCPT ); Wed, 9 Jun 2010 08:35:49 -0400 Received: from casper.infradead.org ([85.118.1.10]:33785 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755554Ab0FIMfr (ORCPT ); Wed, 9 Jun 2010 08:35:47 -0400 Date: Wed, 9 Jun 2010 09:35:30 -0300 From: Arnaldo Carvalho de Melo To: Srikar Dronamraju Cc: Peter Zijlstra , Steven Rostedt , LKML , Ingo Molnar , Frederic Weisbecker , Masami Hiramatsu , Ananth N Mavinakayanahalli Subject: Re: [PATCH][RFC] tracing: Use class->reg() for all registering of events Message-ID: <20100609123530.GB9471@ghostprotocols.net> References: <1276011215.15884.96.camel@gandalf.stny.rr.com> <1276012661.2046.120.camel@twins> <20100608173559.GE2800@linux.vnet.ibm.com> <1276024211.15884.107.camel@gandalf.stny.rr.com> <20100609050534.GA5878@linux.vnet.ibm.com> <1276065150.2046.1004.camel@twins> <20100609114753.GB5878@linux.vnet.ibm.com> <1276084414.2046.1335.camel@twins> <20100609120224.GA8359@ghostprotocols.net> <20100609122338.GA9471@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100609122338.GA9471@ghostprotocols.net> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1920 Lines: 62 Em Wed, Jun 09, 2010 at 09:23:38AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Jun 09, 2010 at 09:02:24AM -0300, Arnaldo Carvalho de Melo escreveu: > > > On Wed, 2010-06-09 at 17:17 +0530, Srikar Dronamraju wrote: > > > > When ran gdb on the core, it showed me that it was dumping in > > > > /usr/lib64/libnewt.so.0.52. in newtScaleSet function. > > > > My newt lib was of version : newt-0.52.2-15 > > Can you please provide a backtrace? I think I know what the problem is, > but I'm not managing to reproduce it here. > > > > > I am now able to workaround the problem by uninstalling newt-devel. If you can reinstall it and then try with the following patch, that is the minimal for .35, I'd appreciate, Thanks, - Arnaldo diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c index cf182ca..059b772 100644 --- a/tools/perf/util/newt.c +++ b/tools/perf/util/newt.c @@ -43,6 +43,12 @@ struct ui_progress *ui_progress__new(const char *title, u64 total) if (self != NULL) { int cols; + /* + * FIXME: We should have a per UI backend way of showing + * progress, stdio will just show a percentage as NN%, etc. + */ + if (use_browser <= 0) + return self; newtGetScreenSize(&cols, NULL); cols -= 4; newtCenteredWindow(cols, 1, title); @@ -67,14 +73,18 @@ out_free_self: void ui_progress__update(struct ui_progress *self, u64 curr) { + if (use_browser <= 0) + return; newtScaleSet(self->scale, curr); newtRefresh(); } void ui_progress__delete(struct ui_progress *self) { - newtFormDestroy(self->form); - newtPopWindow(); + if (use_browser > 0) { + newtFormDestroy(self->form); + newtPopWindow(); + } free(self); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/