Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932086Ab0FIPYu (ORCPT ); Wed, 9 Jun 2010 11:24:50 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:34241 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756152Ab0FIPYs convert rfc822-to-8bit (ORCPT ); Wed, 9 Jun 2010 11:24:48 -0400 Subject: Re: 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection! From: Peter Zijlstra To: Miles Lane Cc: paulmck@linux.vnet.ibm.com, Vivek Goyal , Eric Paris , Lai Jiangshan , Ingo Molnar , LKML , nauman@google.com, eric.dumazet@gmail.com, netdev@vger.kernel.org, Jens Axboe , Gui Jianfeng , Li Zefan , Johannes Berg In-Reply-To: References: <20100608001929.GF2387@linux.vnet.ibm.com> <1275986441.5408.111.camel@twins> <1276004075.2987.208.camel@twins> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Wed, 09 Jun 2010 17:24:28 +0200 Message-ID: <1276097068.1745.13.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 32 On Wed, 2010-06-09 at 11:11 -0400, Miles Lane wrote: > > Sorry. I misunderstood this message when I first read it. I didn't > realize this message include a new version of the patch. > Anyhow, I just tried to apply the patch to 2.6.35-rc2-git3 and got this: > > # patch -p1 -l -F 20 --dry-run < ../5.patch > patching file include/linux/cgroup.h > patching file kernel/sched.c > Hunk #1 succeeded at 306 with fuzz 1. > Hunk #3 FAILED at 4462. > Hunk #4 succeeded at 4487 with fuzz 3. > 1 out of 4 hunks FAILED -- saving rejects to file kernel/sched.c.rej Weird.. it seems to apply without trouble to Linus' git tree. root@twins:/usr/src/linux-2.6# git checkout -f origin/master HEAD is now at 84f7586... Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 root@twins:/usr/src/linux-2.6# quilt push Applying patch patches/sched-rcu-validation.patch patching file include/linux/cgroup.h patching file kernel/sched.c Now at patch patches/sched-rcu-validation.patch root@twins:/usr/src/linux-2.6# git describe v2.6.35-rc2-54-g84f7586 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/