Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758327Ab0FIVV0 (ORCPT ); Wed, 9 Jun 2010 17:21:26 -0400 Received: from casper.infradead.org ([85.118.1.10]:43082 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125Ab0FIVVZ convert rfc822-to-8bit (ORCPT ); Wed, 9 Jun 2010 17:21:25 -0400 Subject: Re: 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection! From: Peter Zijlstra To: Miles Lane Cc: paulmck@linux.vnet.ibm.com, Vivek Goyal , Eric Paris , Lai Jiangshan , Ingo Molnar , LKML , nauman@google.com, eric.dumazet@gmail.com, netdev@vger.kernel.org, Jens Axboe , Gui Jianfeng , Li Zefan , Johannes Berg In-Reply-To: References: <20100608001929.GF2387@linux.vnet.ibm.com> <1275986441.5408.111.camel@twins> <1276004075.2987.208.camel@twins> <1276097068.1745.13.camel@laptop> <1276106229.1745.65.camel@laptop> <1276107311.1745.66.camel@laptop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Wed, 09 Jun 2010 23:20:58 +0200 Message-ID: <1276118458.1745.144.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 21 On Wed, 2010-06-09 at 17:15 -0400, Miles Lane wrote: > On Wed, Jun 9, 2010 at 2:15 PM, Peter Zijlstra wrote: > > On Wed, 2010-06-09 at 19:57 +0200, Peter Zijlstra wrote: > >> + /* > >> + * We're not in the pid-hash yet so no cgroup attach races, and the > >> + * cgroup is pinned by the parent running this. > >> + * > >> + * Silence PROVE_RCU. > >> + */ > > > > Hum,.. not sure that's actually true though, the parent itself is still > > susceptible to races afaict.. > > Do you want what you sent earlier tested, or should I wait for another patch? please wait, I need to sit down and sort out that code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/