Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758588Ab0FIWn0 (ORCPT ); Wed, 9 Jun 2010 18:43:26 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:32529 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756838Ab0FIWnX (ORCPT ); Wed, 9 Jun 2010 18:43:23 -0400 Message-ID: <4C1018C0.6020304@oracle.com> Date: Wed, 09 Jun 2010 15:42:08 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Dmitry Torokhov CC: Stephen Rothwell , Jacob Pan , linux-next@vger.kernel.org, LKML , linux-input@vger.kernel.org, akpm Subject: Re: [PATCH] input: fixup X86_MRST selects References: <20100609133443.38f1f957.sfr@canb.auug.org.au> <20100609152921.61fb7db9.randy.dunlap@oracle.com> <201006091540.43122.dmitry.torokhov@gmail.com> In-Reply-To: <201006091540.43122.dmitry.torokhov@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Auth-Type: Internal IP X-Source-IP: rcsinet15.oracle.com [148.87.113.117] X-CT-RefId: str=0001.0A090206.4C1018FE.0059:SCFMA4539811,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 35 On 06/09/10 15:40, Dmitry Torokhov wrote: > On Wednesday, June 09, 2010 03:29:21 pm Randy Dunlap wrote: >> +++ linux-next-20100609/drivers/input/keyboard/Kconfig >> @@ -70,9 +70,10 @@ config KEYBOARD_ATARI >> >> config KEYBOARD_ATKBD >> tristate "AT keyboard" if EMBEDDED || !X86 >> + depends on !X86 || (X86 && !X86_MRST) > > Should it be simply 'depends on !X86_MRST' and then we could kill > '!X86_MRST' conditionals in selects? Duh, that sounds good, yes. > >> default y >> select SERIO >> - select SERIO_LIBPS2 >> + select SERIO_LIBPS2 if !X86_MRST >> select SERIO_I8042 if X86 && !X86_MRST >> select SERIO_GSCPS2 if GSC >> help > > Thanks. > -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/