Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758577Ab0FJB4w (ORCPT ); Wed, 9 Jun 2010 21:56:52 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:54869 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758558Ab0FJB4u (ORCPT ); Wed, 9 Jun 2010 21:56:50 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; b=w5ZUb8nxuI6EpCxLGqzxglbUZemIej7LeGxLtNvU3YuO4rcKb4dCy15jMKDbGmZg51 3GP2k9+mo8R646Nk6Skm3KgV/oSbqaqjFyvMjsUiHzFqdPg7vD+3ruzAG7UlxzjrE1Un ULEB1LW9JB+pn9hvX4EiByw3r7ftpstOmkHjg= MIME-Version: 1.0 In-Reply-To: <20100609204257.GJ1743@mail.wantstofly.org> References: <4c0ff6b2.0c3ddf0a.2185.2e09@mx.google.com> <20100609203720.GK7660@chipmunk> <20100609203929.GL7660@chipmunk> <20100609204257.GJ1743@mail.wantstofly.org> From: Dmytro Milinevskyy Date: Thu, 10 Jun 2010 04:56:27 +0300 X-Google-Sender-Auth: 9rqY_7d7FM6lrvRv1wNSBzP7YBs Message-ID: Subject: Re: [PATCH] Marvell OpenRD-Ultimate machine support To: Lennert Buytenhek Cc: Alexander Clouter , linux-arm-kernel@lists.infradead.org, Russell King , Dhaval Vasa , Lennert Buytenhek , Nicolas Pitre , Simon Guinot , Martin Michlmayr , Simon Kagstrom , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 478 Lines: 17 Hi! >> >> Better still, just make this 'if(!machine_is_openrd_base())'. > > That form is more error prone when someone adds the OpenRD-SuperDuper, > though. > I agree, and the similar could be done in pcie initialization. -- Dima -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/