Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754800Ab0FJGOq (ORCPT ); Thu, 10 Jun 2010 02:14:46 -0400 Received: from gate.crashing.org ([63.228.1.57]:40631 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712Ab0FJGOp (ORCPT ); Thu, 10 Jun 2010 02:14:45 -0400 Subject: Re: [PATCH 3/5] Removing dead CONFIG_SMP_750 From: Benjamin Herrenschmidt To: Josh Boyer Cc: Christoph Egger , Paul Mackerras , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, vamos@i4.informatik.uni-erlangen.de In-Reply-To: <20100609123557.GJ7801@zod.rchland.ibm.com> References: <8bf8cfaf47590e1a85f9510bb546ca35e3458bf8.1275925219.git.siccegge@cs.fau.de> <20100609123557.GJ7801@zod.rchland.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 10 Jun 2010 16:14:21 +1000 Message-ID: <1276150461.1962.42.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2086 Lines: 59 On Wed, 2010-06-09 at 08:35 -0400, Josh Boyer wrote: > On Wed, Jun 09, 2010 at 12:00:21PM +0200, Christoph Egger wrote: > >CONFIG_SMP_750 doesn't exist in Kconfig, therefore removing all > >references for it from the source code. > > Yeah, we don't support SMP on 750 at the moment. This code was carried over > from the arch/ppc days, and that code was present pre-git. I think we can > drop it, but I'll leave that up to Ben. Maybe he has crazy plans for a 750 SMP > board. Nope :-) Though it would be nice to also remove the call sites too and thus remove the macro entirely. Cheers, Ben. > josh > > > > >Signed-off-by: Christoph Egger > >--- > > arch/powerpc/mm/tlb_hash32.c | 4 ---- > > 1 files changed, 0 insertions(+), 4 deletions(-) > > > >diff --git a/arch/powerpc/mm/tlb_hash32.c b/arch/powerpc/mm/tlb_hash32.c > >index 8aaa8b7..925fecb 100644 > >--- a/arch/powerpc/mm/tlb_hash32.c > >+++ b/arch/powerpc/mm/tlb_hash32.c > >@@ -94,11 +94,7 @@ void tlb_flush(struct mmu_gather *tlb) > > * the cache operations on the bus. Hence we need to use an IPI > > * to get the other CPU(s) to invalidate their TLBs. > > */ > >-#ifdef CONFIG_SMP_750 > >-#define FINISH_FLUSH smp_send_tlb_invalidate(0) > >-#else > > #define FINISH_FLUSH do { } while (0) > >-#endif > > > > static void flush_range(struct mm_struct *mm, unsigned long start, > > unsigned long end) > >-- > >1.6.3.3 > > > >_______________________________________________ > >Linuxppc-dev mailing list > >Linuxppc-dev@lists.ozlabs.org > >https://lists.ozlabs.org/listinfo/linuxppc-dev > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/