Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758802Ab0FJLV5 (ORCPT ); Thu, 10 Jun 2010 07:21:57 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:50161 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753680Ab0FJLVz (ORCPT ); Thu, 10 Jun 2010 07:21:55 -0400 Subject: Re: [PATCH -mm] only drop root anon_vma if not self From: Catalin Marinas To: Dave Young Cc: Rik van Riel , Andrew Morton , Linux Kernel Mailing List , linux-mm@kvack.org In-Reply-To: References: <1275929000.3021.56.camel@e102109-lin.cambridge.arm.com> <20100609211617.3e7e41bd@annuminas.surriel.com> Content-Type: text/plain; charset="UTF-8" Organization: ARM Limited Date: Thu, 10 Jun 2010 12:21:06 +0100 Message-ID: <1276168866.24535.25.camel@e102109-lin.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 10 Jun 2010 11:21:06.0584 (UTC) FILETIME=[04E7D980:01CB088F] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 39 Dave, On Thu, 2010-06-10 at 02:30 +0100, Dave Young wrote: > On Thu, Jun 10, 2010 at 9:16 AM, Rik van Riel wrote: > > On Wed, 9 Jun 2010 17:19:02 +0800 > > Dave Young wrote: > > > >> > Manually bisected mm patches, the memleak caused by following patch: > >> > > >> > mm-extend-ksm-refcounts-to-the-anon_vma-root.patch > >> > >> > >> So I guess the refcount break, either drop-without-get or over-drop > > > > I'm guessing I did not run the kernel with enough debug options enabled > > when I tested my patches... > > > > Dave & Catalin, thank you for tracking this down. > > > > Dave, does the below patch fix your issue? > > Yes, it fixed the issue. Thanks. Thanks for investigating this issue. BTW, without my kmemleak nobootmem patch (and CONFIG_NOBOOTMEM enabled), do you get other leaks (false positives). If my patch fixes the nobootmem problem, can I add a Tested-by: Dave Young? Thanks. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/