Date: Thu, 10 Jun 2010 15:48:48 +0200
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Sachin Sant <sachinp@in.ibm.com>, Avi Kivity <avi@redhat.com>,
       Carsten Otte <cotte@de.ibm.com>,
       Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
       linux-s390@vger.kernel.org, Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: next June 10: S390 build failure [arch/s390/kvm/kvm.ko]
Message-ID: <20100610154848.616aff99@mschwide.boeblingen.de.ibm.com>
In-Reply-To: <4C10DCB7.7090903@in.ibm.com>
References: <20100610160012.30ea7606.sfr@canb.auug.org.au>
	<4C10DCB7.7090903@in.ibm.com>
Organization: IBM Corporation
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1033
Lines: 29

On Thu, 10 Jun 2010 18:08:15 +0530
Sachin Sant <sachinp@in.ibm.com> wrote:

> Today's next fails to build on a s390 box with
> 
> ERROR: "__kvm_s390_vcpu_store_status" [arch/s390/kvm/kvm.ko] undefined!
> 
> Yesterday's next was good.

That is caused by git commit fbc5eec58e652339e9df1332cd5e10e8d8250aaf
which fails to take git commit 5288fbf0ef041ba0e8b4dcb2df4536b5e3a48b32
into account. There is a second caller of __kvm_s390_vcpu_store_status
in arch/s390/kvm/intercept.c. As far as I understand the code you could
just drop the 'static' from kvm_s390_vcpu_store_status and call it from
handle_stop instead of the old __kvm_s390_vcpu_store_status.

Carsten, Christian: could one of you have a look please?

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/