Message-ID: <4C1205DC.1080200@crca.org.au>
Date: Fri, 11 Jun 2010 19:46:04 +1000
From: Nigel Cunningham <ncunningham@crca.org.au>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100423 Thunderbird/3.0.4
MIME-Version: 1.0
To: Jiri Slaby <jslaby@suse.cz>
CC: rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
       linux-kernel@vger.kernel.org, jirislaby@gmail.com
Subject: Re: [linux-pm] [PATCH 1/9] PM / Hibernate: swap,	switch to hibernate_io_handle
References: <1275468768-28229-1-git-send-email-jslaby@suse.cz>
In-Reply-To: <1275468768-28229-1-git-send-email-jslaby@suse.cz>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1097
Lines: 29

Hi.

(Sorry Jiri - unintentionally originally replied only to you).

On 02/06/10 18:52, Jiri Slaby wrote:
 > Hi,
 >
 > I addressed the comments I got on the previous RFC. I left the handles
 > in place, the functions in hibernate_io_ops now works on them. Further
 > I got rid of the memory barriers and minimized global variables as much
 > as possible. Comments welcome.

I would like to hear the arguments for using these handles. I understand 
there may have been some previous discussion, but am unable to find it.

It seems far more sensible to me to not pass around a handle that 
virtually nothing actually uses, and instead store and utilise the state 
in the place where it is actually useful. If we had more than one struct 
hibernate_io_handle in use at a time, I could understand going this way. 
As it stands, however...

Regards,

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/