Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759976Ab0FKLpd (ORCPT ); Fri, 11 Jun 2010 07:45:33 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:51484 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293Ab0FKLpb (ORCPT ); Fri, 11 Jun 2010 07:45:31 -0400 Date: Fri, 11 Jun 2010 13:45:28 +0200 From: Luotao Fu To: Mark Brown Cc: Luotao Fu , Samuel Ortiz , Dmitry Torokhov , Andrew Morton , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] input: STMPE811 touch controller support Message-ID: <20100611114527.GC4078@pengutronix.de> Mail-Followup-To: Mark Brown , Luotao Fu , Samuel Ortiz , Dmitry Torokhov , Andrew Morton , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <1276251195-22981-1-git-send-email-l.fu@pengutronix.de> <1276251195-22981-4-git-send-email-l.fu@pengutronix.de> <20100611112102.GE12436@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iFRdW5/EC4oqxDHL" Content-Disposition: inline In-Reply-To: <20100611112102.GE12436@sirena.org.uk> X-PGP-Key-ID: 0xE5325261 X-URL: http://www.pengutronix.de/ X-Sent-From: Pengutronix Hildesheim X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 13:43:51 up 5:40, 12 users, load average: 0.12, 0.04, 0.01 User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:250:baff:feac:3723 X-SA-Exim-Mail-From: l.fu@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1931 Lines: 58 --iFRdW5/EC4oqxDHL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Jun 11, 2010 at 12:21:02PM +0100, Mark Brown wrote: > On Fri, Jun 11, 2010 at 12:13:15PM +0200, Luotao Fu wrote: >=20 > > +/* > > + * reference source: > > + * > > + * Set ref_sel =3D 0 for internal reference > > + * ref_sel =3D 1 for external reference > > + */ > > +static int ref_sel; > > +module_param(ref_sel, int, 0444); > > +MODULE_PARM_DESC(ref_sel, > > + "Set ADC reference source. Default is 0 (internal reference)"); >=20 > This looks like something that ought to be configured via platform data > since the value that should be used is going to be determined by the > board schematic. Similar comments apply to most of the other module > parameters, though in some cases sysfs files might be more appropriate > as well, or in addition. OK. These stuffs are indeed platform dependent. I'll create a platform data for it than. Thanks Luotao Fu --=20 Pengutronix e.K. | Dipl.-Ing. Luotao Fu | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --iFRdW5/EC4oqxDHL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkwSIdcACgkQkLuxfMCkDTZHzwCeIHO03VV1vYIEHQPbP89A89kK vFUAn3q2Jdw+rW1sUP76h8q7L6u3s6c4 =M0O+ -----END PGP SIGNATURE----- --iFRdW5/EC4oqxDHL-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/