Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755771Ab0FKQ14 (ORCPT ); Fri, 11 Jun 2010 12:27:56 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:50619 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755322Ab0FKQ1z (ORCPT ); Fri, 11 Jun 2010 12:27:55 -0400 Date: Fri, 11 Jun 2010 12:27:51 -0400 From: Christoph Hellwig To: Andrew Morton Cc: Mel Gorman , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel Subject: Re: [PATCH 5/6] vmscan: Write out ranges of pages contiguous to the inode where possible Message-ID: <20100611162751.GB24707@infradead.org> References: <1275987745-21708-1-git-send-email-mel@csn.ul.ie> <1275987745-21708-6-git-send-email-mel@csn.ul.ie> <20100610231045.7fcd6f9d.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100610231045.7fcd6f9d.akpm@linux-foundation.org> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 22 On Thu, Jun 10, 2010 at 11:10:45PM -0700, Andrew Morton wrote: > I did this, umm ~8 years ago and ended up reverting it because it was > complex and didn't seem to buy us anything. Of course, that was before > we broke the VM and started writing out lots of LRU pages. That code > was better than your code - it grabbed the address_space and did > writearound around the target page. > Or don't take a look - we shouldn't need to do any of this anyway. Doing nearly 100% of the writepage from the flusher threads would also be preferable from the filesystem point of view - getting I/O from one thread helps to make it more local and work around all the stupid I/O controller logic that tries to make our life difficult. Of course getting rid of ->writepage from the AOPs API one day would also be nice to simplify the filesystems code, but it's not that important. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/