Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755771Ab0FKUCf (ORCPT ); Fri, 11 Jun 2010 16:02:35 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:31222 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752290Ab0FKUCe (ORCPT ); Fri, 11 Jun 2010 16:02:34 -0400 Date: Fri, 11 Jun 2010 16:02:18 -0400 From: Chris Mason To: Linus Torvalds Cc: linux-kernel , linux-btrfs@vger.kernel.org Subject: Re: [GIT PULL] Btrfs updates for 2.6.35 Message-ID: <20100611200218.GE3018@think> Mail-Followup-To: Chris Mason , Linus Torvalds , linux-kernel , linux-btrfs@vger.kernel.org References: <20100611193731.GA3018@think> <20100611194812.GD3018@think> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Auth-Type: Internal IP X-Source-IP: rcsinet13.oracle.com [148.87.113.125] X-CT-RefId: str=0001.0A090203.4C129650.00EF:SCFMA4539811,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1140 Lines: 27 On Fri, Jun 11, 2010 at 01:00:02PM -0700, Linus Torvalds wrote: > On Fri, Jun 11, 2010 at 12:48 PM, Chris Mason wrote: > > > > The others all fix oopsen or big problems, and I think fixing warnings > > helps avoid false negatives as others look for real problems? > > > > I'm happy to rebase out the 3 non-criticals. > > There seems to be more than three non-criticals. There's the warning > fixes, the "unused variables" thing, the "memdup_user()" thing, a > couple of unnecessary NULL checks removed etc. On the whole, I do not > get the feeling that the pull request was actively trying to be > minimal, and that's what I really want to see. No problem, I like to err on the side of pulling in safe fixes from the automated checkers so they don't have to go through results again. But, I've got a completely minimal rebase now and I'm double checking it. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/