Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760552Ab0FKVZm (ORCPT ); Fri, 11 Jun 2010 17:25:42 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:47438 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756316Ab0FKVZl convert rfc822-to-8bit (ORCPT ); Fri, 11 Jun 2010 17:25:41 -0400 Subject: Re: perf_disable() From: Peter Zijlstra To: Frederic Weisbecker Cc: paulus , stephane eranian , Robert Richter , Will Deacon , Paul Mundt , LKML In-Reply-To: <20100611210405.GC5234@nowhere> References: <1276273784.2077.2055.camel@twins> <20100611210405.GC5234@nowhere> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Fri, 11 Jun 2010 23:25:28 +0200 Message-ID: <1276291528.1745.155.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 728 Lines: 20 On Fri, 2010-06-11 at 23:04 +0200, Frederic Weisbecker wrote: > On Fri, Jun 11, 2010 at 06:29:44PM +0200, Peter Zijlstra wrote: > > There is a fun little recursion issue with perf_adjust_period(), where > > if we fully removed perf_disable() we could end up calling pmu::stop() > > twice and such. > > > > We can have a local_t made nesting level on the stop/start that could easily > deal with this. Fanning it out to the relevant pmu implementation is the interesting part.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/