Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760668Ab0FKXzQ (ORCPT ); Fri, 11 Jun 2010 19:55:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13489 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755839Ab0FKXzO (ORCPT ); Fri, 11 Jun 2010 19:55:14 -0400 Message-ID: <4C12CCD8.4070306@redhat.com> Date: Fri, 11 Jun 2010 18:55:04 -0500 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: Tao Ma CC: Greg Freemyer , linux-ext4@vger.kernel.org, Theodore Tso , linux-kernel@vger.kernel.org Subject: Re: fiemap is broken for sparse file in ext4? References: <4C119C2E.2090801@oracle.com> <4C11B6D8.8070909@redhat.com> <4C11C41C.9070000@oracle.com> <4C125A6C.2090805@redhat.com> <4C126AAB.4040802@redhat.com> <4C12CAD7.3030008@oracle.com> In-Reply-To: <4C12CAD7.3030008@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1727 Lines: 60 Tao Ma wrote: > Hi Eric, > Eric Sandeen wrote: >> Greg Freemyer wrote: >> >>> On Fri, Jun 11, 2010 at 11:46 AM, Eric Sandeen >>> wrote: >>> >>>> Tao Ma wrote: >>>> >>>> >>>>>> What are you using to call fiemap? Here it seems to be working: >>>>>> >>>>> I just wrote a simple test program by calling ioctl. It is attached. >>>>> btw, you need to call it immediately after dd so that we have a chance >>>>> that ext4 don't have time to allocate extents. ;) >>>>> >>>> OK I take it back, I do see it. *cough* too many different filesystems >>>> on this box ... ;) >>>> >>>> Yes, it does look like a bug. >>>> >>>> -Eric >>>> >>> I'm not clear how this is supposed to work. >>> >>> Is this just a userspace bug in that FIEMAP_FLAG_SYNC is needed in the >>> fiemap call, or is there a kernel bug as well? >>> >> >> The flag is optional, though maybe filefrag should use it. >> >> Without it, we should get the proper logical offset and a >> delalloc-flagged >> extent returned >> >> >>> If fiemap is called with the FIEMAP_FLAG_SYNC flag is there currently >>> a problem? >>> >> >> yep, we should get one delalloc extent in the results and we don't. >> > With FIEMAP_FLAG_SYNC set, my test shows that we get one extent without > dealloc flags. So no problem with it. > We have another different test result? ;) No, I misread. :( Calling with FIEMAP_FLAG_SYNC works as expected. -Eric > Regards, > Tao > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/