Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757126Ab0FLB1A (ORCPT ); Fri, 11 Jun 2010 21:27:00 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:43001 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755965Ab0FLB07 convert rfc822-to-8bit (ORCPT ); Fri, 11 Jun 2010 21:26:59 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=Y7AKZMowlGmmrgaaXV1grKolR7PjNQ+c3WG5CdJkh2+4rD3hUgZQVeC8NQoca4Kb8i QybtYntqqAWZPqKpeqeyLTWd3o2PRYO7/6F1XmJqIXyLtFJ4grtoTvUNgoqStKBfcAy2 9VDSNrwVEv72NSWB1F2txZsmBjo3lxdYxtG/c= MIME-Version: 1.0 In-Reply-To: <4C128201.8020104@canonical.com> References: <20100602213429.GA14866@srcf.ucam.org> <57DF5FDC2DC0634FA2A310BC5B81A68D01DF4CD01E@AUSX7MCPC108.AMER.DELL.COM> <57DF5FDC2DC0634FA2A310BC5B81A68D01DFD57663@AUSX7MCPC108.AMER.DELL.COM> <20100610184023.GA17320@srcf.ucam.org> <57DF5FDC2DC0634FA2A310BC5B81A68D01DFD5780A@AUSX7MCPC108.AMER.DELL.COM> <4C124358.8020007@canonical.com> <4C128201.8020104@canonical.com> From: Islam Amer Date: Sat, 12 Jun 2010 04:26:38 +0300 Message-ID: Subject: Re: Dell Studio 1555 eject key does not work ( small patch to fix included ) To: tim.gardner@canonical.com Cc: Rezwanul_Kabir@dell.com, mjg59@srcf.ucam.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, akpm@linux-foundation.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5498 Lines: 174 What would you like me to do now? I want to help :) Thanks. On Fri, Jun 11, 2010 at 9:35 PM, Tim Gardner wrote: > The only difference between 2.6.32.15 and Ubuntu Lucid wrt dell-wmi.c is > this: > > 43,46d42 > < /* Temporary workaround until the WMI sysfs interface goes in. > < ? ?Borrowed from acer-wmi */ > < MODULE_ALIAS("dmi:*:*Dell*:*:"); > < > > I wonder about input event filtering? There are substantial differences in > drivers/input/input.c. > > rtg > > On 06/11/2010 12:02 PM, Islam Amer wrote: >> >> Dear Tim, >> >> I tried the mainline kernel 2.6.32-0206321505-generic as you suggested >> and the eject key doesn't work but it also doesn't produce the error >> message in dmesg. >> >> I then tried the 2.6.32-22.36-generic from >> http://packages.ubuntu.com/lucid/linux-image-2.6.32-22-generic and I >> found the eject key working fine. >> >> So there is something in the ubuntu patchset that fixes this issue. >> >> On Fri, Jun 11, 2010 at 5:23 PM, Islam Amer ?wrote: >>> >>> Tim I am running debian, >>> >>> I think it's the other way round, the mainline kernel is borked ( >>> regarding dell-wmi and eject key ) while the lucid patched kernel >>> works ( as reported by dell team ). >>> >>> I guess I could download a Lucid livecd and see if the eject key works >>> there ( event only as it won't eject the lived while it is running :) >>> ) >>> >>> On Fri, Jun 11, 2010 at 5:08 PM, Tim Gardner >>> ?wrote: >>>> >>>> Islam Amer, >>>> >>>> You could try a vanilla stable kernel from >>>> http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.32.15.5-lucid/ to see >>>> if >>>> we've borked the dell-wmi code. >>>> >>>> rtg >>>> >>>> On 06/11/2010 07:28 AM, Islam Amer wrote: >>>>> >>>>> Rezwanul, >>>>> >>>>> I've updated my bios to A11 and installed a new unmodified kernel. The >>>>> issue still persists that the eject key produces "dell-wmi: Unknown >>>>> key 0 pressed" in the dmesg output and it doesn't work. >>>>> >>>>> It is possible that Ubuntu is including patches to fix stuff. The >>>>> latest patch for the Lucid kernel at >>>>> >>>>> >>>>> http://archive.ubuntu.com/ubuntu/pool/main/l/linux/linux_2.6.32-22.36.diff.gz >>>>> does include patches that touch wmi and dell-wmi code, but I can't >>>>> find a specific change that would fix this issue. >>>>> >>>>> I might try to selectively apply patches from it and see if it gets >>>>> fixed. >>>>> >>>>> Thanks. >>>>> >>>>> >>>>> On Fri, Jun 11, 2010 at 3:15 AM, ? ?wrote: >>>>>> >>>>>> Islam Amer >>>>>> >>>>>> ? Please try the new BIOS A11 and eliminate any potential BIOS issues. >>>>>> The BIOS team confirmed that >>>>>> ? they weren't able to reproduce the issue with Ubuntu 10.04 and A11. >>>>>> >>>>>> Thanks.. >>>>>> ? --rez >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Rezwanul Kabir >>>>>> Dell Linux Development >>>>>> 512-725-0766 >>>>>> >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Islam Amer [mailto:pharon@gmail.com] >>>>>>> Sent: Thursday, June 10, 2010 6:52 PM >>>>>>> To: Matthew Garrett >>>>>>> Cc: Kabir, Rezwanul; linux-kernel@vger.kernel.org; >>>>>>> platform-driver-x86@vger.kernel.org; akpm@linux-foundation.org >>>>>>> Subject: Re: Dell Studio 1555 eject key does not work ( small >>>>>>> patch to fix included ) >>>>>>> >>>>>>> Hello all, >>>>>>> >>>>>>> My bios version is A08 , I see that A11 was recently released >>>>>>> but the changelog doesn't say much. >>>>>>> >>>>>>> Which is better, upgrade and hope the problem goes away, or >>>>>>> wait until we have a fix that is agreed upon ? >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Thu, Jun 10, 2010 at 9:40 PM, Matthew Garrett >>>>>>> ? ?wrote: >>>>>>>> >>>>>>>> On Thu, Jun 10, 2010 at 01:36:56PM -0500, >>>>>>> >>>>>>> Rezwanul_Kabir@Dell.com wrote: >>>>>>>>> >>>>>>>>> Hi Islam Amer >>>>>>>>> >>>>>>>>> ? ?I got report that "Ubuntu 10.04 + BIOS A11" was tested and the >>>>>>>>> "Eject CD" key is working >>>>>>>>> ? ?as expected. Sorry, I couldn't find any Studio 1555 to >>>>>>> >>>>>>> test myself >>>>>>>>> >>>>>>>>> and cannot provide you >>>>>>>>> ? ?with more details. >>>>>>>>> >>>>>>>>> ? ? Also, you may try acpi_osi="Windows 2009" kernel >>>>>>> >>>>>>> parameter and see if there is any difference. >>>>>>>> >>>>>>>> That's the default on any kernel that has this support in dell-wmi. >>>>>>>> Rez, could you let me know if the proposed patch breaks the spec in >>>>>>>> ways that are likely to cause problems? >>>>>>>> >>>>>>>> -- >>>>>>>> Matthew Garrett | mjg59@srcf.ucam.org >>>>>>>> >>>>>>> >>>>> -- >>>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" >>>>> in >>>>> the body of a message to majordomo@vger.kernel.org >>>>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html >>>>> Please read the FAQ at ?http://www.tux.org/lkml/ >>>> >>>> >>>> -- >>>> Tim Gardner tim.gardner@canonical.com >>>> >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at ?http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at ?http://www.tux.org/lkml/ > > > -- > Tim Gardner tim.gardner@canonical.com > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/