Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752587Ab0FLF7n (ORCPT ); Sat, 12 Jun 2010 01:59:43 -0400 Received: from LUNGE.MIT.EDU ([18.54.1.69]:54503 "EHLO lunge.queued.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951Ab0FLF7m (ORCPT ); Sat, 12 Jun 2010 01:59:42 -0400 Date: Sat, 12 Jun 2010 01:59:37 -0400 From: Andres Salomon To: Andrew Morton Cc: Dave Young , linux-kernel@vger.kernel.org Subject: Re: mmotm 2010-06-11-16-40 uploaded Message-ID: <20100612015937.1981f1b6@dev.queued.net> In-Reply-To: <20100611195421.6b723910.akpm@linux-foundation.org> References: <201006120008.o5C08gC3027843@imap1.linux-foundation.org> <20100611195421.6b723910.akpm@linux-foundation.org> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.12.12; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2464 Lines: 78 On Fri, 11 Jun 2010 19:54:21 -0700 Andrew Morton wrote: > On Sat, 12 Jun 2010 10:43:31 +0800 Dave Young > wrote: > > > On Sat, Jun 12, 2010 at 7:40 AM, wrote: > > > The mm-of-the-moment snapshot 2010-06-11-16-40 has been uploaded > > > to > > > > > > __ http://userweb.kernel.org/~akpm/mmotm/ > > > > > > and will soon be available at > > > > > > __ git://zen-kernel.org/kernel/mmotm.git > > > > > > > Hi, andrew > > > > building failed with: > > AS arch/x86/kernel/entry_32.o > > /home/dave/src/linux-2.6.35/arch/x86/include/asm/olpc_ofw.h: > > Assembler > > messages: /home/dave/src/linux-2.6.35/arch/x86/include/asm/olpc_ofw.h:29: > > Error: no such instruction: `static inline void > > olpc_ofw_detect_range(void){}' make[2]: *** > > [arch/x86/kernel/entry_32.o] Error 1 make[1]: *** [arch/x86/kernel] > > Error 2 make: *** [arch/x86] Error 2 > > > > Attached a patch to fix it (I have not appropriate email client now, > > sorry for the inconvenience ) > > Thanks. > > We can simplify things a bit I think... > > #ifndef _ASM_X86_OLPC_OFW_H > #define _ASM_X86_OLPC_OFW_H > > /* hardcode addresses to make life easier dealing w/ VMALLOC_END and > others */ #define OLPC_OFW_START 0xff800000UL > #define OLPC_OFW_SIZE (PGDIR_SIZE) > #define OLPC_OFW_END (OLPC_OFW_START + OLPC_OFW_SIZE) > > #ifndef __ASSEMBLER__ > > #ifdef CONFIG_OLPC_OPENFIRMWARE > > /* address of OFW callback interface; will be NULL if OFW isn't found > */ extern int (*olpc_ofw_cif)(int *); > > /* page dir entry containing OFW's current memory */ > extern pgdval_t olpc_ofw_pgd; > > /* run an OFW command by calling into the firmware */ > extern int olpc_ofw(const char *name, int nr_args, int nr_res, ...); > > /* determine/ensure OFW lives in the proper place in (virtual) memory > */ void olpc_ofw_detect_range(void); > > #else /* CONFIG_OLPC_OPENFIRMWARE */ > > static inline void olpc_ofw_detect_range(void) { } > > #endif /* CONFIG_OLPC_OPENFIRMWARE */ > > #endif /* __ASSEMBLER__ */ > > #endif > Thanks, I've changed it to something similar in my git tree. It'll be in the next patch (once I've addressed hpa's concerns). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/