Date: Sun, 13 Jun 2010 12:01:21 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Divyesh Shah <dpshah@google.com>
Cc: jaxboe@fusionio.com, peterz@infradead.org, piotr@hosowicz.com,
       linux-kernel@vger.kernel.org, vgoyal@redhat.com,
       Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] Remove preempt_enable/disable calls around
 sched_clock()
Message-ID: <20100613100121.GC12322@elte.hu>
References: <20100612023409.14850.76309.stgit@austin.mtv.corp.google.com>
 <20100612071950.GB29751@elte.hu>
 <AANLkTimcB3Jzb0b9pw5YOs5qmeznlcNFOqm64TBqOEdr@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTimcB3Jzb0b9pw5YOs5qmeznlcNFOqm64TBqOEdr@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 883
Lines: 27


* Divyesh Shah <dpshah@google.com> wrote:

> On Sat, Jun 12, 2010 at 12:19 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Divyesh Shah <dpshah@google.com> wrote:
> >
> >> calls in the block layer. This was a temporary fix added.
> >
> > Not good, this commit reintroduces those ugly warnings, if someone happens to
> > bisect straight into this commit.
> 
> You're right. In the next version, I'll merge both patches into one so
> this cannot happen.

Yeah - or if you really want to make a point of doing the two things in two 
separate patches you can first fix the API, _then_ remove the preemption 
enable/disable.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/