Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755240Ab0FNCHk (ORCPT ); Sun, 13 Jun 2010 22:07:40 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:48778 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753351Ab0FNCHi (ORCPT ); Sun, 13 Jun 2010 22:07:38 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Message-ID: <4C158EC3.3010601@jp.fujitsu.com> Date: Mon, 14 Jun 2010 11:06:59 +0900 From: Kenji Kaneshige User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: "H. Peter Anvin" CC: Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org Subject: Re: [PATCH 3/4] x86: ioremap: remove physical address warning message References: <4C11FF10.4060203@jp.fujitsu.com> <4C11FFF6.8040406@jp.fujitsu.com> <4C127604.6000203@zytor.com> In-Reply-To: <4C127604.6000203@zytor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1839 Lines: 49 (2010/06/12 2:44), H. Peter Anvin wrote: > On 06/11/2010 02:20 AM, Kenji Kaneshige wrote: >> Current ioremap() code for x86 displays warning message if too high >> address to handle is passed. But this can happen as usual cases. For >> example, if 64-bit BAR is assigned to a PCI device and its device >> driver calls pci_iomap(). So this patch changes the warning messages >> as follows. >> >> - Change printk message from KERN_WARNING to KERN_DEBUG >> - Remove WARN_ON_ONCE() >> >> Signed-off-by: Kenji Kaneshige >> >> --- >> arch/x86/mm/ioremap.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> Index: linux-2.6.34/arch/x86/mm/ioremap.c >> =================================================================== >> --- linux-2.6.34.orig/arch/x86/mm/ioremap.c 2010-06-10 07:28:31.966187993 +0900 >> +++ linux-2.6.34/arch/x86/mm/ioremap.c 2010-06-10 07:28:33.146375380 +0900 >> @@ -78,9 +78,8 @@ >> return NULL; >> >> if (!phys_addr_valid(phys_addr)) { >> - printk(KERN_WARNING "ioremap: invalid physical address %llx\n", >> + printk(KERN_DEBUG "ioremap: can't map physical address %llx\n", >> (unsigned long long)phys_addr); >> - WARN_ON_ONCE(1); >> return NULL; >> } >> > > Fair to change the message, but the priority level really seems way > insufficient. I can see dropping the WARN_ON_ONCE() though. > I think KERN_WARNING is a little too high because there is no action user can take and there is no problem from the hardware/firmware point of view. How about KERN_INFO instead? Thanks, Kenji Kaneshige -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/