Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754591Ab0FNLWM (ORCPT ); Mon, 14 Jun 2010 07:22:12 -0400 Received: from verein.lst.de ([213.95.11.210]:34908 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874Ab0FNLWK (ORCPT ); Mon, 14 Jun 2010 07:22:10 -0400 Date: Mon, 14 Jun 2010 13:21:50 +0200 From: Christoph Hellwig To: Adrian Hunter Cc: Christoph Hellwig , "jens.axboe@oracle.com" , Andrew Morton , Kyungmin Park , LKML , "linux-mmc@vger.kernel.org" , Madhusudhan Chikkature Subject: Re: [PATCH V2 0/4] Add MMC erase and secure erase Message-ID: <20100614112150.GA5364@lst.de> References: <4C14AC7E.6030308@nokia.com> <20100614080921.GA28316@lst.de> <4C160E0E.4010802@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C160E0E.4010802@nokia.com> User-Agent: Mutt/1.3.28i X-Spam-Score: 0 () Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 19 On Mon, Jun 14, 2010 at 02:10:06PM +0300, Adrian Hunter wrote: > Needs a bio flag, a request flag, setup the request flag based on the > bio flag, prevent merging secure and non-secure discards, prevent drivers > doing non-secure discards for secure discards. > > Seems like a lot of little changes for something that no one wants. > Shouldn't it wait for someone to need it first? I know that some people have asked for this. But if you want to keep it in the driver for now that's fine to me. But in that case please: (a) make it entirely driver private and leave no traces of it in the block layer (b) split it into a separate patch from the discard support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/