Date: Mon, 14 Jun 2010 14:36:52 +0200
From: Johannes Stezenbach <js@sig21.net>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, linux-kernel@vger.kernel.org
Subject: Re: FIGETBSZ ioctl conflict
Message-ID: <20100614123652.GA312@sig21.net>
References: <20100614110252.GB32224@sig21.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100614110252.GB32224@sig21.net>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 931
Lines: 25

(forgot to add lkml to Cc)

On Mon, Jun 14, 2010 at 01:02:52PM +0200, Johannes Stezenbach wrote:
> Hi,
> 
> in commit 19ba0559 the FIGETBSZ (and FS_IOC_FIEMAP) ioctl was moved
> from file_ioctl() to do_vfs_ioctl(), so it also works for directories.
> The problem I'm seeing is that FIGETBSZ is defined as _IO(0x00,2)
> which is simply 2.  so there is some potential for conflicts
> with character devices which do not use the _IO macros for numbering
> their ioctls.
> Just doing a web search for "FIGETBSZ ioctl conflict" shows
> that a few people already ran into this problem.
> 
> Would you mind adding a check for S_ISDIR | S_ISREG,
> or maybe !S_ISCHR?
> 
> 
> Thanks,
> Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/