Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754732Ab0FNO7Z (ORCPT ); Mon, 14 Jun 2010 10:59:25 -0400 Received: from casper.infradead.org ([85.118.1.10]:60123 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753369Ab0FNO7Y (ORCPT ); Mon, 14 Jun 2010 10:59:24 -0400 Date: Mon, 14 Jun 2010 08:01:54 -0700 From: Arjan van de Ven To: Sergey Senozhatsky Cc: "Rafael J. Wysocki" , Maxim Levitsky , Len Brown , Pavel Machek , Jiri Slaby , Andrew Morton , linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: BUG: using smp_processor_id() in preemptible code: s2disk Message-ID: <20100614080154.7d6a71fc@infradead.org> In-Reply-To: <20100614145439.GA3448@swordfish.minsk.epam.com> References: <20100613203352.GA3577@swordfish> <1276461183.2659.4.camel@maxim-laptop> <201006140136.18652.rjw@sisk.pl> <20100614140941.GA3581@swordfish.minsk.epam.com> <20100614073853.6fa2f91f@infradead.org> <20100614145439.GA3448@swordfish.minsk.epam.com> Organization: Intel X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 39 On Mon, 14 Jun 2010 17:54:40 +0300 Sergey Senozhatsky wrote: > On (06/14/10 07:38), Arjan van de Ven wrote: > > > Hello, > > > Not sure if this simple solution is the correct one. > > > > it's not; the caller needs to pass in the cpu number I suspect for > > this to be really correct.... > > > > I just returned from family emergency travel and will take a look > > today > > > > I thought about patching > > ./drivers/cpuidle/governors/menu.c: if (nr_iowait_cpu()) > ./drivers/cpuidle/governors/menu.c: mult += 10 * > nr_iowait_cpu(); ./kernel/time/tick-sched.c: if > (nr_iowait_cpu() > 0) > > > decided to patch nr_iowait_cpu instead. the bug is that it needs to be nr_iowait_cpu(int cpu) -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/