Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657Ab0FNPZF (ORCPT ); Mon, 14 Jun 2010 11:25:05 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:60354 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401Ab0FNPZC (ORCPT ); Mon, 14 Jun 2010 11:25:02 -0400 Date: Mon, 14 Jun 2010 11:25:02 -0400 From: Christoph Hellwig To: Dave Chinner Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk, josef@redhat.com, jeffmerkey@gmail.com Subject: Re: [PATCH 5/5] fsfreeze: move emergency thaw code to fs/super.c Message-ID: <20100614152502.GE32354@infradead.org> References: <1276154395-24766-1-git-send-email-david@fromorbit.com> <1276154395-24766-6-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1276154395-24766-6-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 888 Lines: 24 On Thu, Jun 10, 2010 at 05:19:54PM +1000, Dave Chinner wrote: > From: Dave Chinner > > It makes no sense having the emergency thaw code in fs/buffer.c when all of > it's operations are one superblocks and the code it executes is all in > fs/super.c. Move the code there and clean it up. > +static void thaw_super_emergency(struct super_block *sb, void *unused) > +{ > + > + if (sb->s_bdev) { > + char b[BDEVNAME_SIZE]; > + printk(KERN_WARNING "Emergency Thaw on %s.\n", > + bdevname(sb->s_bdev, b)); > + } > + while (!__thaw_super(sb, 1)); Please move the ; to a separate line to make the loop better redable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/