Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755746Ab0FNQKk (ORCPT ); Mon, 14 Jun 2010 12:10:40 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:40841 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753790Ab0FNQKh (ORCPT ); Mon, 14 Jun 2010 12:10:37 -0400 Date: Mon, 14 Jun 2010 17:10:34 +0100 From: Mark Brown To: Peter Huewe Cc: Liam Girdwood , linux-sh@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , Guennadi Liakhovetski , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc/sh: Fix I2C dependency for SND_FSI_AK4642 Message-ID: <20100614161034.GF14604@rakim.wolfsonmicro.main> References: <201006141739.42346.PeterHuewe@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006141739.42346.PeterHuewe@gmx.de> X-Cookie: I brake for chezlogs! User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 15 On Mon, Jun 14, 2010 at 05:39:41PM +0200, Peter Huewe wrote: > bool "FSI-AK4642 sound support" > depends on SND_SOC_SH4_FSI > select SND_SOC_AK4642 > + select I2C I'd have thought a depends was more appropriate. Arguably you want to depend on the SH I2C driver since the driver is useless without the relevant I2C controller. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/