Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754708Ab0FNToO (ORCPT ); Mon, 14 Jun 2010 15:44:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30280 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357Ab0FNToM (ORCPT ); Mon, 14 Jun 2010 15:44:12 -0400 Message-ID: <4C168640.6080309@redhat.com> Date: Mon, 14 Jun 2010 15:42:56 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: Mel Gorman CC: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki , Andrew Morton Subject: Re: [PATCH 10/12] vmscan: Update isolated page counters outside of main path in shrink_inactive_list() References: <1276514273-27693-1-git-send-email-mel@csn.ul.ie> <1276514273-27693-11-git-send-email-mel@csn.ul.ie> In-Reply-To: <1276514273-27693-11-git-send-email-mel@csn.ul.ie> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 18 On 06/14/2010 07:17 AM, Mel Gorman wrote: > When shrink_inactive_list() isolates pages, it updates a number of > counters using temporary variables to gather them. These consume stack > and it's in the main path that calls ->writepage(). This patch moves the > accounting updates outside of the main path to reduce stack usage. > > Signed-off-by: Mel Gorman > Reviewed-by: Johannes Weiner Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/