Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756326Ab0FOCWS (ORCPT ); Mon, 14 Jun 2010 22:22:18 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:43157 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752875Ab0FOCWQ (ORCPT ); Mon, 14 Jun 2010 22:22:16 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Message-ID: <4C16E3B1.8010107@jp.fujitsu.com> Date: Tue, 15 Jun 2010 11:21:37 +0900 From: Kenji Kaneshige User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: "H. Peter Anvin" CC: KAMEZAWA Hiroyuki , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org Subject: Re: [PATCH 2/4] x86: ioremap: fix physical address check References: <4C11FF10.4060203@jp.fujitsu.com> <4C11FFC0.1030006@jp.fujitsu.com> <4C1275BF.3070605@zytor.com> <20100614091823.34fac7a6.kamezawa.hiroyu@jp.fujitsu.com> <20100614175912.976f5878.kamezawa.hiroyu@jp.fujitsu.com> <4C15F2BD.9020904@jp.fujitsu.com> <4C160D27.1050809@jp.fujitsu.com> <4C1676C0.60105@zytor.com> In-Reply-To: <4C1676C0.60105@zytor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 31 (2010/06/15 3:36), H. Peter Anvin wrote: > On 06/14/2010 04:06 AM, Kenji Kaneshige wrote: >> Index: linux-2.6.34/include/linux/vmalloc.h >> =================================================================== >> --- linux-2.6.34.orig/include/linux/vmalloc.h >> +++ linux-2.6.34/include/linux/vmalloc.h >> @@ -30,7 +30,7 @@ struct vm_struct { >> unsigned long flags; >> struct page **pages; >> unsigned int nr_pages; >> - unsigned long phys_addr; >> + phys_addr_t phys_addr; >> void *caller; >> }; > > This really doesn't look right at all. If this was required then it > would seem that anything using high addresses would be broken... as such > I can only assume it matters only for lowmem pages... > Without this change, /pric/vmallocinfo doesn't display physcal address info properly (need also to change s_show() in mm/vmalloc (%lx in seq_printf()). Thanks, Kenji Kaneshige -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/