Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750829Ab0FOEB7 (ORCPT ); Tue, 15 Jun 2010 00:01:59 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:48560 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750701Ab0FOEB5 (ORCPT ); Tue, 15 Jun 2010 00:01:57 -0400 Date: Tue, 15 Jun 2010 09:30:01 +0530 From: Srikar Dronamraju To: Christoph Hellwig Cc: Peter Zijlstra , Ingo Molnar , Masami Hiramatsu , Mel Gorman , Randy Dunlap , Arnaldo Carvalho de Melo , Steven Rostedt , "H. Peter Anvin" , Roland McGrath , Linus Torvalds , Ananth N Mavinakayanahalli , Oleg Nesterov , Mark Wielaard , Mathieu Desnoyers , LKML , Jim Keniston , Frederic Weisbecker , "Rafael J. Wysocki" , "Frank Ch. Eigler" , Andrew Morton , "Paul E. McKenney" Subject: Re: [PATCH v5 2/14] mm: Move replace_page to mm/memory.c Message-ID: <20100615040001.GD13800@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20100614082748.29068.21995.sendpatchset@localhost6.localdomain6> <20100614082818.29068.35191.sendpatchset@localhost6.localdomain6> <20100614174441.GC23754@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20100614174441.GC23754@infradead.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 30 > On Mon, Jun 14, 2010 at 01:58:18PM +0530, Srikar Dronamraju wrote: > > move_replace_page.patch > > > > From: Srikar Dronamraju > > > > Move replace_page() and write_protect_page() to mm/memory.c > > > > User bkpt will use background page replacement approach to insert/delete > > breakpoints. Background page replacement approach will be based on > > replace_page and write_protect_page. > > Now replace_page() loses its static attribute. > > Neither of these actually gets used in this series. So you can drop > the patch for now. replace_page() and write_protect_page() are used in write_opcode() to insert/remove a breakpoint in the user-space breakpoint insertion layer. i.e "[PATCH v5 3/14] User Space Breakpoint Assistance Layer" Even if we merge uprobes and user_bkpt layers, we would still need write_opcode function while inserting/deleting a breakpoint. -- Thanks and Regards Srikar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/