Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754529Ab0FOHkl (ORCPT ); Tue, 15 Jun 2010 03:40:41 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:43931 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752631Ab0FOHkk (ORCPT ); Tue, 15 Jun 2010 03:40:40 -0400 Date: Tue, 15 Jun 2010 03:40:28 -0400 From: Christoph Hellwig To: Andi Kleen Cc: Dave Chinner , xfs@oss.sgi.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unused statement warnings Message-ID: <20100615074028.GA15322@infradead.org> References: <20100610110.764742110@firstfloor.org> <20100610111052.3DDC5B1A2B@basil.firstfloor.org> <20100614042700.GC6590@dastard> <20100614074309.GA17092@basil.fritz.box> <20100614133755.GE6590@dastard> <20100614143720.GI17092@basil.fritz.box> <20100614222458.GF6590@dastard> <20100615070244.GD6727@basil.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100615070244.GD6727@basil.fritz.box> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 19 On Tue, Jun 15, 2010 at 09:02:45AM +0200, Andi Kleen wrote: > I suspect you miss quite a lot of valuable information from > your user base by not supporting kerneloops.org. On the other > hand it would likely also save you from spending time on > flakes. > > That said you don't need BUG_ON to support it (WARN etc. work > too), it's just the easiest way. Note that a XFS filesystem shutdown already gives a stack trace. But picking up every filesystem shutdown on kerneloops.org seems to be quite a bit too much. It's usually due to IO errors from the underlying device. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/