Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755290Ab0FOM1j (ORCPT ); Tue, 15 Jun 2010 08:27:39 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:64944 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753522Ab0FOM1i (ORCPT ); Tue, 15 Jun 2010 08:27:38 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=OSZ2y6aYbtpXyncFAxMfpJ5VBSDjGtuOtIxErOx9h9QzZYWKlx36To1UTKLZAN1puY nkfH8cEl41RIJe3hMOE+EgPLwmpPRu3NvqQxEPesGjqChrtzjWc0XCb4hpe0Vxv7UxFS C42XARUcTtwML4NuJcSZyNv1rszGmkvi3TNik= Message-ID: <4C176C66.20008@gmail.com> Date: Tue, 15 Jun 2010 14:04:54 +0200 From: Maurus Cuelenaere User-Agent: Mozilla/5.0 (X11; U; Linux i686; nl; rv:1.9.1.9) Gecko/20100317 Lightning/1.0b1 Thunderbird/3.0.4 MIME-Version: 1.0 To: Jassi Brar CC: Kukjin Kim , Linus Walleij , Dan Williams , linux-arm-kernel@lists.infradead.org, yuanyabin1978@sina.com, Viresh Kumar , Alessandro Rubini , linux-kernel@vger.kernel.org, Ben Dooks , Peter Pearse Subject: Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL081 PrimeCells References: <1276270031-1607-1-git-send-email-linus.walleij@stericsson.com> <002001cb0c75$0a54fd00$1efef700$%kim@samsung.com> <4C176148.4020507@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2195 Lines: 53 Op 15-06-10 13:39, Jassi Brar schreef: > On Tue, Jun 15, 2010 at 8:17 PM, Maurus Cuelenaere > wrote: > >> Op 15-06-10 12:45, Jassi Brar schreef: >> >>> On Tue, Jun 15, 2010 at 7:25 PM, Kukjin Kim wrote: >>> >>>> Linus Walleij wrote: >>>> >>>>> This creates a DMAengine driver for the ARM PL080/PL081 PrimeCells >>>>> based on the implementation earlier submitted by Peter Pearse. >>>>> This is working like a charm for memcpy on the PB11MPCore, but >>>>> slave DMA to devices is still not working. >>>>> >>>>> This DMA controller is used in mostly unmodified form in the ARM >>>>> RealView and Versatile platforms, in the ST-Ericsson Nomadik, and >>>>> in the ST SPEAr platform. >>>>> >>>>> It has been converted to use the header from the Samsung PL080 >>>>> derivate instead of its own defintions, and can potentially support >>>>> several controllers in the same system. >>>>> >>>>> Cc: Peter Pearse >>>>> Cc: Ben Dooks >>>>> Cc: Kukjin Kim >>>>> >>>> Looks good, but please give me some time to test on the board(SMDK6410). >>>> If any problem, let you know. Of course no problem, will ack. >>>> >>> Samsung doesn't use the DMA API, so this driver is unlikely to work. >>> >> It doesn't indeed, but it could be adapted to be a wrapper around the DMA engine API. >> Or even better, the drivers could be adapted to use that API. >> > I don't particularly like the idea of making Samsung's drivers use the DMA API. > IMHO the S3C dma api is better atm. > At the moment it is better, true. But I do think it'd be better to use a generic API than an arch-specific one. I'm not familiar enough with both of them to know what functionality is currently missing but I do think that once the DMA engine API is up to speed, it should replace the s3c one. -- Maurus Cuelenaere -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/