Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166Ab0FOM4y (ORCPT ); Tue, 15 Jun 2010 08:56:54 -0400 Received: from THUNK.ORG ([69.25.196.29]:37607 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633Ab0FOM4x (ORCPT ); Tue, 15 Jun 2010 08:56:53 -0400 Date: Tue, 15 Jun 2010 08:56:50 -0400 From: tytso@mit.edu To: Andrew Morton Cc: Salman , mingo@elte.hu, linux-kernel@vger.kernel.org, peterz@infradead.org, tytso@google.com, torvalds@linux-foundation.org, walken@google.com, Chen Liqin , Lennox Wu Subject: Re: [PATCH] Fix a race in pid generation that causes pids to be reused immediately. Message-ID: <20100615125650.GL6666@thunk.org> Mail-Followup-To: tytso@mit.edu, Andrew Morton , Salman , mingo@elte.hu, linux-kernel@vger.kernel.org, peterz@infradead.org, tytso@google.com, torvalds@linux-foundation.org, walken@google.com, Chen Liqin , Lennox Wu References: <20100611224902.5039.60134.stgit@bumblebee1.mtv.corp.google.com> <20100614165851.6bdfe485.akpm@linux-foundation.org> <20100615005619.GI6666@thunk.org> <20100614185556.afdc5304.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100614185556.afdc5304.akpm@linux-foundation.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 567 Lines: 15 On Mon, Jun 14, 2010 at 06:55:56PM -0700, Andrew Morton wrote: > > I think you're probably right, as long as one sticks with 4-byte > scalars. The cmpxchg-is-now-generic change snuck in under the radar > (mine, at least). Hmmm, what about unsigned longs? (Which might be 8 bytes on some architectures....) - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/