Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757895Ab0FOOtP (ORCPT ); Tue, 15 Jun 2010 10:49:15 -0400 Received: from mail.gmx.net ([213.165.64.20]:46053 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752850Ab0FOOtN (ORCPT ); Tue, 15 Jun 2010 10:49:13 -0400 X-Authenticated: #12255092 X-Provags-ID: V01U2FsdGVkX1/dxfUKfezdfWEBTwULQ2Xg9u5hrrrDtasera5M5E +IJO/ouo+RX3Wr From: Peter =?iso-8859-1?q?H=FCwe?= To: Mark Brown Subject: Re: [PATCH] soc/sh: Fix I2C dependency for SND_FSI_AK4642 Date: Tue, 15 Jun 2010 16:49:07 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.34; KDE/4.3.5; x86_64; ; ) Cc: Liam Girdwood , linux-sh@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , Guennadi Liakhovetski , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <201006141739.42346.PeterHuewe@gmx.de> <20100614161034.GF14604@rakim.wolfsonmicro.main> In-Reply-To: <20100614161034.GF14604@rakim.wolfsonmicro.main> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201006151649.07554.PeterHuewe@gmx.de> X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1149 Lines: 34 Am Montag 14 Juni 2010 18:10:34 schrieb Mark Brown: > On Mon, Jun 14, 2010 at 05:39:41PM +0200, Peter Huewe wrote: > > bool "FSI-AK4642 sound support" > > depends on SND_SOC_SH4_FSI > > select SND_SOC_AK4642 > > + select I2C > > I'd have thought a depends was more appropriate. Arguably you want to > depend on the SH I2C driver since the driver is useless without the > relevant I2C controller. > Thanks for pointing this out - I had also a closer look at the codecs and the other FSI related codec (da7210.c) depends on I2C too. So maybe even move the dependency up to SND_SOC_SH4_FSI since both codecs rely on I2C? So something like this would be more appropriate? config SND_SOC_SH4_FSI tristate "SH4 FSI support" + depends on CONFIG_I2C_SH_MOBILE help This option enables FSI sound support If you think this patch sounds correct, I can create a new 'official' patch. Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/