Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758049Ab0FOPFk (ORCPT ); Tue, 15 Jun 2010 11:05:40 -0400 Received: from casper.infradead.org ([85.118.1.10]:55342 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756732Ab0FOPFi (ORCPT ); Tue, 15 Jun 2010 11:05:38 -0400 Date: Tue, 15 Jun 2010 08:08:08 -0700 From: Arjan van de Ven To: Sergey Senozhatsky Cc: "Rafael J. Wysocki" , Maxim Levitsky , Len Brown , Pavel Machek , Jiri Slaby , Andrew Morton , linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] avoid using smp_processor_id() in preemptible code (nr_iowait_cpu) Message-ID: <20100615080808.6286448b@infradead.org> In-Reply-To: <20100615145029.GB3967@swordfish.minsk.epam.com> References: <1276461183.2659.4.camel@maxim-laptop> <201006140136.18652.rjw@sisk.pl> <20100614140941.GA3581@swordfish.minsk.epam.com> <20100614073853.6fa2f91f@infradead.org> <20100614145439.GA3448@swordfish.minsk.epam.com> <20100614080154.7d6a71fc@infradead.org> <20100614151735.GB3448@swordfish.minsk.epam.com> <20100614204021.52c50cdc@infradead.org> <20100615061927.GA3312@swordfish> <20100615072435.5a47d850@infradead.org> <20100615145029.GB3967@swordfish.minsk.epam.com> Organization: Intel X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 29 On Tue, 15 Jun 2010 17:50:29 +0300 Sergey Senozhatsky wrote: > > > > hmm this part is wrong > > you pick the current cpu, rather than the one denoted by ts..... > > > > Hmm. Thanks, good catch. > Well, there is something I'm missing. How can I match given *ts and > cpu in update_ts_time_stats (except for introducing > update_ts_time_stats(..., int cpu)) ? that'd be option one option two is to add a "cpu" member to struct tick_sched..... if you go for option one, I'd replace the ts argument with the cpu argument..... -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/