Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757639Ab0FOQfF (ORCPT ); Tue, 15 Jun 2010 12:35:05 -0400 Received: from hera.kernel.org ([140.211.167.34]:56791 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757527Ab0FOQfC (ORCPT ); Tue, 15 Jun 2010 12:35:02 -0400 Message-ID: <4C17AB91.1040207@kernel.org> Date: Tue, 15 Jun 2010 18:34:25 +0200 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: mingo@elte.hu, tglx@linutronix.de, bphilips@suse.de, yinghai@kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, jeff@garzik.org, linux-ide@vger.kernel.org, stern@rowland.harvard.edu, gregkh@suse.de, khali@linux-fr.org Subject: Re: [PATCH 02/12] irq: make spurious poll timer per desc References: <1276443098-20653-1-git-send-email-tj@kernel.org> <1276443098-20653-3-git-send-email-tj@kernel.org> <20100615051027.GA8073@phenom.dumpdata.com> In-Reply-To: <20100615051027.GA8073@phenom.dumpdata.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Tue, 15 Jun 2010 16:34:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 964 Lines: 25 On 06/15/2010 07:10 AM, Konrad Rzeszutek Wilk wrote: >> @@ -169,6 +170,7 @@ struct irq_2_iommu; >> * @pending_mask: pending rebalanced interrupts >> * @threads_active: number of irqaction threads currently running >> * @wait_for_threads: wait queue for sync_irq to wait for threaded handlers >> + * @poll_timer: timer for IRQ polling > > I looked over the patches and they all look good to my eyes. > > The only thing that looked out of place was the above comment. > Would it make sense to move the comment one tab to the left? When applied, it will show up at the right place. It's because the first tab ends next to ':' and the leading '+' ends up pushing it to the next tab position. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/