Subject: Re: [PATCH] uniform cdrom: fix mutex unlocking in
 /proc/sys/dev/cdrom/info file
From: Davidlohr Bueso <dave.bueso@gmail.com>
Reply-To: dave.bueso@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
In-Reply-To: <20100614123417.444a82c3.akpm@linux-foundation.org>
References: <1276102610.5572.32.camel@cowboy>
	 <20100614123417.444a82c3.akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 15 Jun 2010 14:40:54 -0400
Message-ID: <1276627254.4666.0.camel@cowboy>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1309
Lines: 44

On Mon, 2010-06-14 at 12:34 -0700, Andrew Morton wrote:
> On Wed, 09 Jun 2010 12:56:50 -0400
> Davidlohr Bueso <dave.bueso@gmail.com> wrote:
> 
> > If the last if condition passes the cdrom_mutex mutex will not be unlocked. 
> > This patch fixes this and also removes the unnecessary doit label that was only invoked by the done label.
> > 
> 
> Confused.  There is no way in which cdrom_sysctl_info() can forget to
> unlock cdrom_mutex.
> 

Ok, I had misread the code then, one of the reasons I don't like goto
labels, but that's a different story.

Regarding cdrom_sysctl_info(), I have noticed in several netbooks
(haven't
looked in other machines with no cdrom drive) that the
/proc/sys/dev/cdrom/info file shows no values for the listed entries,
ie:

CD-ROM information, Id: cdrom.c 3.20 2003/12/17

drive name:
drive speed:
drive # of slots:
Can close tray:
Can open tray:
...

Now, is this expected behavior? If not, should it be changed to
something
more descriptive? Perhaps it would affect user space applications that
read
the file?

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/