Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758857Ab0FPLfv (ORCPT ); Wed, 16 Jun 2010 07:35:51 -0400 Received: from faui40.informatik.uni-erlangen.de ([131.188.34.40]:43808 "EHLO faui40.informatik.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754671Ab0FPLfu (ORCPT ); Wed, 16 Jun 2010 07:35:50 -0400 Date: Wed, 16 Jun 2010 13:35:48 +0200 From: Christoph Egger To: Shane McDonald Cc: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, vamos@i4.informatik.uni-erlangen.de Subject: Re: [PATCH 5/9] Removing dead CONFIG_BLK_DEV_IDE Message-ID: <20100616113548.GA10065@faui48a.informatik.uni-erlangen.de> References: <73e9e4bd7615488c9567f02f8962825386956365.1275925108.git.siccegge@cs.fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 48 On Thu, Jun 10, 2010 at 12:23:06PM -0600, Shane McDonald wrote: > I wonder if, instead of deleting the code, the constant should be > changed from CONFIG_BLK_DEV_IDE to CONFIG_IDE. The original > patch that removed CONFIG_BLK_DEV_IDE seemed to make this change: > http://kerneltrap.org/mailarchive/linux-kernel/2008/8/13/2929444 > > Shane You're probably right, updated patch below ------- From: Christoph Egger Date: Mon, 7 Jun 2010 17:29:48 +0200 Subject: [PATCH 5/9] Removing dead CONFIG_BLK_DEV_IDE CONFIG_BLK_DEV_IDE doesn't exist in Kconfig, therefore removing all references for it from the source code. Signed-off-by: Christoph Egger --- diff --git a/arch/mips/mti-malta/malta-setup.c b/arch/mips/mti-malta/malta-setup.c index b7f37d4..f6a5ea8 100644 --- a/arch/mips/mti-malta/malta-setup.c +++ b/arch/mips/mti-malta/malta-setup.c @@ -105,7 +105,7 @@ static void __init fd_activate(void) } #endif -#ifdef CONFIG_BLK_DEV_IDE +#ifdef CONFIG_IDE static void __init pci_clock_check(void) { unsigned int __iomem *jmpr_p = @@ -207,7 +207,7 @@ void __init plat_mem_setup(void) if (mips_revision_sconid == MIPS_REVISION_SCON_BONITO) bonito_quirks_setup(); -#ifdef CONFIG_BLK_DEV_IDE +#ifdef CONFIG_IDE pci_clock_check(); #endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/