From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Subject: Re: [PATCH 5/5]scsi:hosts.c Fix warning: variable 'rval' set but not used
Date: Wed, 16 Jun 2010 19:25:43 +0200
User-Agent: KMail/1.13.3 (Linux/2.6.31.5-0.1-desktop; KDE/4.4.85; i686; ; )
Cc: James Bottomley <James.Bottomley@suse.de>, linux-kernel@vger.kernel.org,
       linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org,
       linux-scsi@vger.kernel.org
References: <1276666434-11227-1-git-send-email-justinmattock@gmail.com> <1276702443.2847.153.camel@mulgrave.site> <4C18F524.4000902@gmail.com>
In-Reply-To: <4C18F524.4000902@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart4375284.Rhr4l8mgtq";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <201006161925.43956.eike-kernel@sf-tec.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2207
Lines: 64

--nextPart4375284.Rhr4l8mgtq
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Justin P. Mattock wrote:
> On 06/16/2010 08:34 AM, James Bottomley wrote:

> > However, I don't think we should be ignoring the fact that the eh thread
> > failed to spawn, so I think some type of printed warning (giving the
> > error code) would be a much more appropriate replacement.

> o.k. I'll give a try at that.. as a  test I did this(below) seemed to
> compile clean, but not sure if this is what you're asking for though:

> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index 6660fa9..8d98a46 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -325,7 +325,6 @@ struct Scsi_Host *scsi_host_alloc(struct
> scsi_host_template *sht, int privsize)
>   {
>   	struct Scsi_Host *shost;
>   	gfp_t gfp_mask =3D GFP_KERNEL;
> -	int rval;
>=20
>   	if (sht->unchecked_isa_dma && privsize)
>   		gfp_mask |=3D __GFP_DMA;
> @@ -420,7 +419,7 @@ struct Scsi_Host *scsi_host_alloc(struct
> scsi_host_template *sht, int privsize)
>   	shost->ehandler =3D kthread_run(scsi_error_handler, shost,
>   			"scsi_eh_%d", shost->host_no);
>   	if (IS_ERR(shost->ehandler)) {
> -		rval =3D PTR_ERR(shost->ehandler);
> +		printk(KERN_WARNING "test.....\n");
>   		goto fail_kfree;
>   	}

If you want to print anything here I think the error code would be a good=20
thing to include as that could give a hint _what_ actually went wrong. In t=
hat=20
case you would need rval, but IMHO it should be declared inside that if=20
clause.

Eike

--nextPart4375284.Rhr4l8mgtq
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)

iEYEABECAAYFAkwZCRcACgkQXKSJPmm5/E7CFQCfacAXhWr0yWSrv2m/nT+o8Bqi
RY8AnjDJroak2bG5ozIQTz1oDhpPYB+D
=eSwC
-----END PGP SIGNATURE-----

--nextPart4375284.Rhr4l8mgtq--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/