Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759337Ab0FPSOv (ORCPT ); Wed, 16 Jun 2010 14:14:51 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:56701 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753517Ab0FPSOs (ORCPT ); Wed, 16 Jun 2010 14:14:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=DOebUqbZjvSJjlE2Oz9mZKxdFU0aAmJrolJA3vdbh76d4cg/IYWQAfFgmxFRUhAFGB lLvQuoFYvP+JjfjDZJFbV6H5dufjcw2R4qZSkN78k4sXWL/GFfbvCoddr7rzHDEYICmf nB7efWHT4e/GzmNdc8True+LKJ9j6C+Y7cCp0= Message-ID: <4C19147E.6050006@gmail.com> Date: Wed, 16 Jun 2010 11:14:22 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091114 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: James Bottomley CC: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 5/5]scsi:hosts.c Fix warning: variable 'rval' set but not used References: <1276666434-11227-1-git-send-email-justinmattock@gmail.com> <1276666434-11227-6-git-send-email-justinmattock@gmail.com> <1276702443.2847.153.camel@mulgrave.site> <4C18F524.4000902@gmail.com> <1276709590.2847.176.camel@mulgrave.site> In-Reply-To: <1276709590.2847.176.camel@mulgrave.site> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4569 Lines: 128 On 06/16/2010 10:33 AM, James Bottomley wrote: > On Wed, 2010-06-16 at 09:00 -0700, Justin P. Mattock wrote: >> On 06/16/2010 08:34 AM, James Bottomley wrote: >>> On Tue, 2010-06-15 at 22:33 -0700, Justin P. Mattock wrote: >>>> The below patch fixes a warning message generated by gcc 4.6.0 >>>> CC drivers/scsi/hosts.o >>>> drivers/scsi/hosts.c: In function 'scsi_host_alloc': >>>> drivers/scsi/hosts.c:328:6: warning: variable 'rval' set but not used >>>> >>>> Signed-off-by: Justin P. Mattock >>>> >>>> --- >>>> drivers/scsi/hosts.c | 2 -- >>>> 1 files changed, 0 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c >>>> index 6660fa9..00fd6a4 100644 >>>> --- a/drivers/scsi/hosts.c >>>> +++ b/drivers/scsi/hosts.c >>>> @@ -325,7 +325,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) >>>> { >>>> struct Scsi_Host *shost; >>>> gfp_t gfp_mask = GFP_KERNEL; >>>> - int rval; >>>> >>>> if (sht->unchecked_isa_dma&& privsize) >>>> gfp_mask |= __GFP_DMA; >>>> @@ -420,7 +419,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) >>>> shost->ehandler = kthread_run(scsi_error_handler, shost, >>>> "scsi_eh_%d", shost->host_no); >>>> if (IS_ERR(shost->ehandler)) { >>>> - rval = PTR_ERR(shost->ehandler); >>>> goto fail_kfree; >>>> } >>> >>> For future reference, this is less stylistically acceptable C: you've >>> reduced the if clause to a single statement, so the braces need >>> removing. >>> >>> However, I don't think we should be ignoring the fact that the eh thread >>> failed to spawn, so I think some type of printed warning (giving the >>> error code) would be a much more appropriate replacement. >>> >>> James >>> >>> >>> >> >> >> o.k. I'll give a try at that.. as a test I did this(below) seemed to >> compile clean, but not sure if this is what you're asking for though: >> >> >> From 8a4d6e793e0f92d180a6f48c53bbf00d2751ad01 Mon Sep 17 00:00:00 2001 >> From: Justin P. Mattock >> Date: Wed, 16 Jun 2010 08:58:13 -0700 >> Subject: [PATCH] test >> Signed-off-by: Justin P. Mattock >> >> --- >> drivers/scsi/hosts.c | 3 +-- >> 1 files changed, 1 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c >> index 6660fa9..8d98a46 100644 >> --- a/drivers/scsi/hosts.c >> +++ b/drivers/scsi/hosts.c >> @@ -325,7 +325,6 @@ struct Scsi_Host *scsi_host_alloc(struct >> scsi_host_template *sht, int privsize) >> { >> struct Scsi_Host *shost; >> gfp_t gfp_mask = GFP_KERNEL; >> - int rval; >> >> if (sht->unchecked_isa_dma&& privsize) >> gfp_mask |= __GFP_DMA; >> @@ -420,7 +419,7 @@ struct Scsi_Host *scsi_host_alloc(struct >> scsi_host_template *sht, int privsize) >> shost->ehandler = kthread_run(scsi_error_handler, shost, >> "scsi_eh_%d", shost->host_no); >> if (IS_ERR(shost->ehandler)) { >> - rval = PTR_ERR(shost->ehandler); >> + printk(KERN_WARNING "test.....\n") > > Erm, well, as I said, error code and the fact that the thread failed to > start, so more > > printk(KERN_WARNING "scsi%d: error handler thread failed to spawn, error > = %d\n", host->host_no, PTR_ERR(shost->ehandler)); > > James > > > > yeah I figured the printk needed more. I was more concerned with making sure this is what you are asking for(which looks like it is). So I added your printk but ended up getting an undeclared error: CC drivers/scsi/hosts.o drivers/scsi/hosts.c: In function 'scsi_host_alloc': drivers/scsi/hosts.c:422:85: error: 'host' undeclared (first use in this function) drivers/scsi/hosts.c:422:85: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [drivers/scsi/hosts.o] Error 1 make[1]: *** [drivers/scsi] Error 2 make: *** [drivers] Error 2 I do see a shost->host_no but using this seems to not satisfy the compiler: drivers/scsi/hosts.c: In function 'scsi_host_alloc': drivers/scsi/hosts.c:422:3: warning: format '%d' expects type 'int', but argument 3 has type 'long int' I guess it's safe to say my newbieness is getting my a** kicked with code(all part of the learning experience..) Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/