Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759652Ab0FPUrZ (ORCPT ); Wed, 16 Jun 2010 16:47:25 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51594 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759527Ab0FPUrX (ORCPT ); Wed, 16 Jun 2010 16:47:23 -0400 Date: Wed, 16 Jun 2010 13:46:46 -0700 From: Andrew Morton To: Samuel Thibault Cc: Jiri Slaby , rpurdie@rpsys.net, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@gmail.com, Alessandro Zummo Subject: Re: [PATCH 1/1] LEDS: leds-input, fix sleep inside atomic Message-Id: <20100616134646.3f7870e7.akpm@linux-foundation.org> In-Reply-To: <20100605234505.GZ5358@const.famille.thibault.fr> References: <1275772342-25094-1-git-send-email-jslaby@suse.cz> <20100605234505.GZ5358@const.famille.thibault.fr> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 25 On Sun, 6 Jun 2010 01:45:06 +0200 Samuel Thibault wrote: > Jiri Slaby, le Sat 05 Jun 2010 23:12:22 +0200, a __crit : > > Fix this by changing the spinlock to mutex as it is used only in > > input_handler->connect and ->disconnect and it is safe to sleep > > there. > > Right. in a previous patch it was also used in interrupt context, but > now it should be safe indeed. > > Andrew, please fold it into the leds-input patch. hm, I did, nine days ago; btw, leds-route-kbd-leds-through-the-generic-leds-layer.patch is still in the "stuck" state coz Alessandro said he'd test it ;) I think I'll start pestering Richard with it anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/