Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932709Ab0FPVCA (ORCPT ); Wed, 16 Jun 2010 17:02:00 -0400 Received: from kroah.org ([198.145.64.141]:35309 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932652Ab0FPVBu (ORCPT ); Wed, 16 Jun 2010 17:01:50 -0400 Date: Wed, 16 Jun 2010 13:53:32 -0700 From: Greg KH To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Magnus Damm , "Rafael J. Wysocki" , Paul Mundt , Dmitry Torokhov , Eric Miao , netdev@vger.kernel.org Subject: Re: [PATCH 2/2] Driver core: reduce duplicated code Message-ID: <20100616205332.GB15837@kroah.com> References: <1276591677-4678-1-git-send-email-u.kleine-koenig@pengutronix.de> <1276591677-4678-2-git-send-email-u.kleine-koenig@pengutronix.de> <20100615090500.GA17595@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100615090500.GA17595@pengutronix.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 36 On Tue, Jun 15, 2010 at 11:05:00AM +0200, Uwe Kleine-K?nig wrote: > Hello, > > On Tue, Jun 15, 2010 at 10:47:56AM +0200, Uwe Kleine-K?nig wrote: > > This makes the two similar functions platform_device_register_simple > > and platform_device_register_data one line inline functions using a new > > generic function platform_device_register_resndata. > I forgot to add some comments to this mail, ... sorry. > > - I'm not completely happy with the name of the new function. If > someone has a better name please tell me. I don't like it either, what is "resndata" supposed to stand for? > - can platform_device_register_resndata be moved to __init_or_module? I doubt it, but try it and see if a build warns about it. > - I moved the kernel docs to the header but didn't test if they are > picked up when generating docs. Even if not, there is no better > place, is there? No, that's the proper place, but make sure the docbook source is also picking up the .h file, I don't know if it currently does. So, I'll not apply this one just yet. Can you verify the docbook stuff at the very least? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/