Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759671Ab0FQBxv (ORCPT ); Wed, 16 Jun 2010 21:53:51 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:47707 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759376Ab0FQBvp (ORCPT ); Wed, 16 Jun 2010 21:51:45 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: LKML , linux-mm , Andrew Morton , David Rientjes , Minchan Kim , KAMEZAWA Hiroyuki Subject: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed() Cc: kosaki.motohiro@jp.fujitsu.com In-Reply-To: <20100617104311.FB7A.A69D9226@jp.fujitsu.com> References: <20100617104311.FB7A.A69D9226@jp.fujitsu.com> Message-Id: <20100617104719.FB8C.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Thu, 17 Jun 2010 10:51:42 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1457 Lines: 50 Now has_intersects_mems_allowed() has own thread iterate logic, but it should use while_each_thread(). It slightly improve the code readability. Reviewed-by: Minchan Kim Signed-off-by: KOSAKI Motohiro --- mm/oom_kill.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 541a59b..b27db90 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -46,10 +46,10 @@ static DEFINE_SPINLOCK(zone_scan_lock); * shares the same mempolicy nodes as current if it is bound by such a policy * and whether or not it has the same set of allowed cpuset nodes. */ -static bool has_intersects_mems_allowed(struct task_struct *tsk, +static bool has_intersects_mems_allowed(struct task_struct *p, const nodemask_t *mask) { - struct task_struct *start = tsk; + struct task_struct *tsk = p; do { if (mask) { @@ -69,8 +69,8 @@ static bool has_intersects_mems_allowed(struct task_struct *tsk, if (cpuset_mems_allowed_intersects(current, tsk)) return true; } - tsk = next_thread(tsk); - } while (tsk != start); + } while_each_thread(p, tsk); + return false; } #else -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/