Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750898Ab0FQEAG (ORCPT ); Thu, 17 Jun 2010 00:00:06 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:52314 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756869Ab0FQEAE convert rfc822-to-8bit (ORCPT ); Thu, 17 Jun 2010 00:00:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=ajwkpoSAv1IL554XAazReJThg18hI0OebPCIIOmTkwmF9Mkaha8gplc0Mgq0kCQE9k lldaBPClOdtCF+uyReeMsn44wjL/UxBBuHyFgQZfaX1OCKHNmDyKcHTF/qBfl2auuRJv BUzmUP68me9kpc+Ad+tXHAdAYiuPxXIyF27Kg= MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 17 Jun 2010 00:00:01 -0400 X-Google-Sender-Auth: CQfs1jriiPuv9tR0hGIVAROgw3E Message-ID: Subject: Re: bnx2 fails to compile on parisc because of missing get_dma_ops() From: Mike Frysinger To: Michael Chan Cc: James Bottomley , "netdev@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , FUJITA Tomonori Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 42 On Wed, Jun 16, 2010 at 11:53 PM, Michael Chan wrote: > Mike Frysinger wrote: >> > The commit that causes the problem: >> > >> > commit a33fa66bcf365ffe5b79d1ae1d3582cc261ae56e >> > Author: Michael Chan >> > Date: ? Thu May 6 08:58:13 2010 +0000 >> > >> > ? ?bnx2: Add prefetches to rx path. >> > >> > Looks fairly innocuous by the description. >> > >> > Should parisc have a get_dma_ops()? ?We don't need one >> because our dma >> > ops are per platform not per bus. >> >> looks like it'll be broken on more than just parisc: >> $ grep get_dma_ops arch/*/include/asm/ -rl | cut -d/ -f 2 >> alpha >> ia64 >> microblaze >> powerpc >> sh >> sparc >> x86 > > Most of these archs use the dma functions in: > > > > so it's not a problem. the grep is showing only the arches that define get_dma_ops (and so the new code works). you'd have to invert the list to see the ones which do not define get_dma_ops(), and the inverted list is larger. that was merely my point. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/