Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759811Ab0FQKqn (ORCPT ); Thu, 17 Jun 2010 06:46:43 -0400 Received: from gir.skynet.ie ([193.1.99.77]:54252 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756455Ab0FQKqm (ORCPT ); Thu, 17 Jun 2010 06:46:42 -0400 Date: Thu, 17 Jun 2010 11:46:23 +0100 From: Mel Gorman To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki Subject: Re: [PATCH 09/12] vmscan: Setup pagevec as late as possible in shrink_page_list() Message-ID: <20100617104623.GB25567@csn.ul.ie> References: <1276514273-27693-1-git-send-email-mel@csn.ul.ie> <1276514273-27693-10-git-send-email-mel@csn.ul.ie> <20100616164801.9d3c0d99.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100616164801.9d3c0d99.akpm@linux-foundation.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 34 On Wed, Jun 16, 2010 at 04:48:01PM -0700, Andrew Morton wrote: > On Mon, 14 Jun 2010 12:17:50 +0100 > Mel Gorman wrote: > > > shrink_page_list() sets up a pagevec to release pages as according as they > > are free. It uses significant amounts of stack on the pagevec. This > > patch adds pages to be freed via pagevec to a linked list which is then > > freed en-masse at the end. This avoids using stack in the main path that > > potentially calls writepage(). > > > > hm, spose so. I cen't see any trivial way to eliminate the local > pagevec there. > > > + if (pagevec_count(&freed_pvec)) > > + __pagevec_free(&freed_pvec); > > ... > > - if (pagevec_count(&freed_pvec)) > > - __pagevec_free(&freed_pvec); > > That's an open-coded pagevec_free(). > Fair point, will correct. Thanks -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/