Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760116Ab0FQOKl (ORCPT ); Thu, 17 Jun 2010 10:10:41 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:64574 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752999Ab0FQOKk (ORCPT ); Thu, 17 Jun 2010 10:10:40 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=mT5N6KKt/ysPeZwlDP5Q87loxGcmFhfbrLEgxiH9go+gJKyRfHUsjIcQA4u7bM+5Ww OFIHCFuE0SpluqOkVNoGsHxNui3TYqs69TTOdBwPj/KJZVjoS0FhRzfxTt2NOzJEpi35 4D7Cb0dNiLyAs1CfOVruhUOXJUZI6Asa1UyWI= MIME-Version: 1.0 In-Reply-To: References: <20100617155420.GB2693@localhost.localdomain> Date: Thu, 17 Jun 2010 22:10:39 +0800 Message-ID: Subject: Re: [PATCH] Slabinfo: Fix display format From: wzt wzt To: Christoph Lameter Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@cs.helsinki.fi, mpm@selenic.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 19 On Thu, Jun 17, 2010 at 9:45 PM, Christoph Lameter wrote: > On Thu, 17 Jun 2010, wzt.wzt@gmail.com wrote: > This one may break user space tools that have assumptions about the length > of the field. Or do tools not make that assumption? > User space tools usually use sscanf() to extract this field like: sscanf(buff, "%s %d", name, &num); If %-27s can break some user space tools that have assumptions about the length of the field, the orig %-17s can also break it. The longest name inotify_event_private_data is 26 bytes in 2.6.34-rc2, the tools still can't extract it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/