Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760113Ab0FQOOy (ORCPT ); Thu, 17 Jun 2010 10:14:54 -0400 Received: from mail.gmx.net ([213.165.64.20]:59506 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752999Ab0FQOOw (ORCPT ); Thu, 17 Jun 2010 10:14:52 -0400 X-Authenticated: #14349625 X-Provags-ID: V01U2FsdGVkX1+kiqgbAaukEoAqEBLdmLSdH3vA97mldvo4fztUih gZQlG3LLKhz52v Subject: Re: Slow pty's (was Re: libdivecomputer interfaces?) From: Mike Galbraith To: Peter Zijlstra Cc: Jiri Kosina , Brian Bloniarz , Chris Wedgwood , Linus Torvalds , Greg KH , Alan Cox , OGAWA Hirofumi , Jef Driesen , linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner In-Reply-To: <1276781044.27822.309.camel@twins> References: <20100610181042.GA19210@puku.stupidest.org> <4C116652.8010408@athenacr.com> <1276701411.30669.6.camel@marge.simson.net> <1276756770.8248.20.camel@marge.simson.net> <1276758038.9628.1.camel@marge.simson.net> <1276771844.8121.14.camel@marge.simson.net> <1276781044.27822.309.camel@twins> Content-Type: text/plain Date: Thu, 17 Jun 2010 16:14:46 +0200 Message-Id: <1276784086.8316.17.camel@marge.simson.net> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1.1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1372 Lines: 42 On Thu, 2010-06-17 at 15:24 +0200, Peter Zijlstra wrote: > Humm,. the code around there suggests something like the below, but I > must admit its been a while since I really read all that nohz stuff, > Thomas, any preferences? Mine works. Yours fits and works. -+ vs ----+, you win :) > --- > kernel/time/tick-sched.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c > index 5f171f0..e0707ea 100644 > --- a/kernel/time/tick-sched.c > +++ b/kernel/time/tick-sched.c > @@ -315,9 +315,6 @@ void tick_nohz_stop_sched_tick(int inidle) > goto end; > } > > - if (nohz_ratelimit(cpu)) > - goto end; > - > ts->idle_calls++; > /* Read jiffies and the time when jiffies were updated last */ > do { > @@ -328,7 +325,7 @@ void tick_nohz_stop_sched_tick(int inidle) > } while (read_seqretry(&xtime_lock, seq)); > > if (rcu_needs_cpu(cpu) || printk_needs_cpu(cpu) || > - arch_needs_cpu(cpu)) { > + arch_needs_cpu(cpu) || nohz_ratelimit(cpu)) { > next_jiffies = last_jiffies + 1; > delta_jiffies = 1; > } else { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/