Date: Thu, 17 Jun 2010 16:56:55 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Joel Becker <Joel.Becker@oracle.com>
Cc: Tejun Heo <tj@kernel.org>, mingo@elte.hu, awalls@radix.net,
       linux-kernel@vger.kernel.org, jeff@garzik.org, rusty@rustcorp.com.au,
       cl@linux-foundation.org, dhowells@redhat.com, arjan@linux.intel.com,
       johannes@sipsolutions.net, oleg@redhat.com, axboe@kernel.dk,
       Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: Overview of concurrency managed workqueue
Message-Id: <20100617165655.757d221a.akpm@linux-foundation.org>
In-Reply-To: <20100617232502.GB7981@mail.oracle.com>
References: <1276551467-21246-1-git-send-email-tj@kernel.org>
	<4C17C598.7070303@kernel.org>
	<20100617161412.08337bc6.akpm@linux-foundation.org>
	<20100617232502.GB7981@mail.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1014
Lines: 26

On Thu, 17 Jun 2010 16:25:03 -0700
Joel Becker <Joel.Becker@oracle.com> wrote:

> On Thu, Jun 17, 2010 at 04:14:12PM -0700, Andrew Morton wrote:
> > flush_workqueue() sucks.  It's a stupid, accidental,
> > internal-implementation-dependent interface.  We should deprecate it
> > and try to get rid of it, migrating to the eminently more sensible
> > flush_work().
> > 
> > I guess the first step is to add a dont-do-that checkpatch warning when
> > people try to add new flush_workqueue() calls.
> > 
> > 165 instances tree-wide, sigh.
> 
> 	What would the API be for "I want this workqueue emptied before
> I shut this thing down?"

Um, yeah.  flush_workqueue() is legitimate.  I was thinking of
flush_scheduled_work() - the one which operates on the keventd queue.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/