Date: Thu, 17 Jun 2010 19:37:58 -0700
From: Greg KH <gregkh@suse.de>
To: DDD <dongdong.deng@windriver.com>
Cc: Greg KH <greg@kroah.com>, jason.wessel@windriver.com,
       galak@kernel.crashing.org, bruce.ashfield@windriver.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: cpm_uart: implement the cpm_uart_early_write()
 function for console poll
Message-ID: <20100618023758.GA10393@suse.de>
References: <1276744420-7845-1-git-send-email-dongdong.deng@windriver.com>
 <20100617173101.GB24362@kroah.com>
 <4C1AD5A8.1030203@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C1AD5A8.1030203@windriver.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1070
Lines: 31

On Fri, Jun 18, 2010 at 10:10:48AM +0800, DDD wrote:
> Greg KH wrote:
> >On Thu, Jun 17, 2010 at 11:13:40AM +0800, Dongdong Deng wrote:
> >>The cpm_uart_early_write() function which was used for console poll
> >>isn't implemented in the cpm uart driver.
> >>
> >>Implementing this function both fixes the build and allows
> >>kgdboc to work via the cpm uart.
> >
> >So this is needed for the .35 release, right?  Any older kernel releases
> >as well?
> 
> Yes, it is needed for the .35 release.
> 
> The cpm_uart_early_write() of cpm_uart was introduced at 2.6.27,
> so this patch is needed from 2.6.27.

So no one has noticed that the driver doesn't build at all since the .27
kernel release?  Over 2 years?  I hardly think that it's a rush to fix
it over the next few weeks then :)

I'll go queue it up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/