Date: Fri, 18 Jun 2010 13:28:17 +0900
From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
       linux-kernel@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
       Adam Litke <agl@us.ibm.com>, Avi Kivity <avi@redhat.com>,
       Izik Eidus <ieidus@redhat.com>, Nick Piggin <npiggin@suse.de>,
       Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
       Dave Hansen <dave@linux.vnet.ibm.com>,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       Ingo Molnar <mingo@elte.hu>, Mike Travis <travis@sgi.com>,
       KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
       Christoph Lameter <cl@linux-foundation.org>,
       Chris Wright <chrisw@sous-sol.org>, bpicco@redhat.com,
       KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       Balbir Singh <balbir@linux.vnet.ibm.com>,
       "Michael S. Tsirkin" <mst@redhat.com>,
       Peter Zijlstra <peterz@infradead.org>,
       Johannes Weiner <hannes@cmpxchg.org>,
       Chris Mason <chris.mason@oracle.com>, Borislav Petkov <bp@alien8.de>,
       Hugh Dickins <hughd@google.com>
Subject: Re: [RFC][BUGFIX][PATCH 0/2] transhuge-memcg: some fixes (Re:
 Transparent Hugepage Support #25)
Message-Id: <20100618132817.657f69b9.nishimura@mxp.nes.nec.co.jp>
In-Reply-To: <20100618010840.GE5787@random.random>
References: <20100521000539.GA5733@random.random>
	<20100602144438.dc04ece7.nishimura@mxp.nes.nec.co.jp>
	<20100618010840.GE5787@random.random>
Organization: NEC Soft, Ltd.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1600
Lines: 36

On Fri, 18 Jun 2010 03:08:40 +0200, Andrea Arcangeli <aarcange@redhat.com> wrote:
> On Wed, Jun 02, 2010 at 02:44:38PM +0900, Daisuke Nishimura wrote:
> > These are trial patches to fix the problem(based on THP-25).
> > 
> > [1/2] is a simple bug fix, and can be folded into "memcg compound(commit d16259c1
> > at the http://git.kernel.org/?p=linux/kernel/git/andrea/aa.git)".
> > [2/2] is a main patch.
> > 
> > Unfortunately, there seems to be some problems left, so I'm digging it and
> > need more tests.
> > Any comments are welcome.
> 
> Both are included in -26, but like you said there are problems
> left... are you willing to fix those too?
Will do if necessary, but hmm, I heard from KAMEZAWA-san that he has already sent
some patches to fix the similar problems on RHEL6, and I prefer his fixes to mine.
Should I(or KAMEZAWA-san?) forward port his patches onto current aa.git ?

> There's some slight
> difference in the code here and there that makes the fixes not so
> portable across releases (uncharge as param of move_account which
> wasn't there before as an example...).
> 
Agreed. And I think you'll see some extra changes of memcg in 2.6.36...
Any way, I'll do some test in both RHEL6 and aa.git when I have a time,
and feel free to tell me if you have any troubles in back/forward porting
memcg's fixes.


Thanks,
Daisuke Nishimura.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/