Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761015Ab0FRLjP (ORCPT ); Fri, 18 Jun 2010 07:39:15 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:1753 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758137Ab0FRLjN (ORCPT ); Fri, 18 Jun 2010 07:39:13 -0400 Message-ID: <000401cb0eda$df624590$66f8800a@maildom.okisemi.com> From: "Masayuki Ohtake" To: "Wang, Yong Y" Cc: "Wang, Qi" , "Clark, Joel" , "Khor, Andrew Chih Howe" , "LKML" References: <4C0CE88C.9050708@dsn.okisemi.com> <4C161BE7.4080805@dsn.okisemi.com> <4C198BD2.8060801@dsn.okisemi.com> Subject: Re: [PATCH] Topcliff PHUB: Generate PacketHub driver Date: Fri, 18 Jun 2010 20:39:09 +0900 X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1983 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1983 X-Hosting-Pf: 0 X-NAI-Spam-Score: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3109 Lines: 96 Hi Yong Y >> +config PCH_IEEE1588 >> + tristate "PCH IEEE1588" >> + depends on PCI >> + help >> + If you say yes to this option, support will be included for the >> + PCH IEEE1588 Host controller. >> + >Is this really supposed to be part of this patch? > +obj-$(CONFIG_PCH_IEEE1588) += pch_ieee1588/ > + Yes, the above is true. Our driver under 'drivers/char' has patch order restriction. Firstly, ieee1588 must be patched. After the above, Phub is able to be patched. Thus, our Phub patch includes ieee1588 code. > Ohtak-san, I remember you said PCH_CAN_PCLK_50MHZ was in the patch > because you used to have a hw bug. If that hw bug has been fixed, this config > option shall also be removed. Otherwise, you have to build multiple kernel > binaries for different hardware configurations as Alan pointed out. Sorry, I gave wrong information to you. Our CAN HW spec is that works only 50MHz.(Not HW bug) According to our CAN hw spec, we will delete 'PCH_CAN_PCLK_50MHZ'. Thanks, Ohtake ----- Original Message ----- From: "Wang, Yong Y" To: "Masayuki Ohtak" Cc: "LKML" ; "Khor, Andrew Chih Howe" ; "Clark, Joel" ; "Wang, Qi" Sent: Friday, June 18, 2010 5:08 PM Subject: RE: [PATCH] Topcliff PHUB: Generate PacketHub driver > +config PCH_IEEE1588 > + tristate "PCH IEEE1588" > + depends on PCI > + help > + If you say yes to this option, support will be included for the > + PCH IEEE1588 Host controller. > + Is this really supposed to be part of this patch? > +config PCH_PHUB > + tristate "PCH PHUB" > + depends on PCI > + help > + If you say yes to this option, support will be included for the > + PCH Packet Hub Host controller. > + This driver is for PCH Packet hub driver for Topcliff. > + This driver is integrated as built-in. > + This driver can access GbE MAC address. > + This driver can access HW register. > + You can also be integrated as module. > + > +config PCH_CAN_PCLK_50MHZ > + bool "CAN PCLK 50MHz" > + depends on PCH_PHUB > + help > + If you say yes to this option, clock is set to 50MHz.(For CAN > control) > + Ohtak-san, I remember you said PCH_CAN_PCLK_50MHZ was in the patch because you used to have a hw bug. If that hw bug has been fixed, this config option shall also be removed. Otherwise, you have to build multiple kernel binaries for different hardware configurations as Alan pointed out. > diff --git a/drivers/char/Makefile b/drivers/char/Makefile > index f957edf..dc092d0 100644 > --- a/drivers/char/Makefile > +++ b/drivers/char/Makefile > @@ -111,6 +111,10 @@ obj-$(CONFIG_PS3_FLASH) += ps3flash.o > obj-$(CONFIG_JS_RTC) += js-rtc.o > js-rtc-y = rtc.o > > +obj-$(CONFIG_PCH_IEEE1588) += pch_ieee1588/ > + Ditto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/