DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=xYBxzradvbgPZxEONohXufymyP3DktiflejkCyj85jfxYUnuNbFtuPJsa9DntQfF5T
         SJrSfFPtPndnbhyat4lNV8OVeXX/ZIPDIbIclZKLM3QjaN2qMbhrXZXQehmbrd8qKpve
         2jOLPq2uW2tdmg8duBzLVb+SBPq1XHEd6WWl8=
Subject: Re: [PATCH] pci: Don't enable aspm before drivers have had a
 chance to veto it
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Matthew Garrett <mjg@redhat.com>,
       Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
       "Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>,
       linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <20100618101506.0c585617@virtuousgeek.org>
References: <1276113907-22432-1-git-send-email-mjg@redhat.com>
	 <1276862811.19918.10.camel@maxim-laptop>
	 <20100618091255.2db036ea@virtuousgeek.org>
	 <1276880742.23783.7.camel@maxim-laptop>
	 <20100618101506.0c585617@virtuousgeek.org>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 18 Jun 2010 20:44:18 +0300
Message-ID: <1276883058.23783.10.camel@maxim-laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2673
Lines: 62

On Fri, 2010-06-18 at 10:15 -0700, Jesse Barnes wrote: 
> On Fri, 18 Jun 2010 20:05:42 +0300
> Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> 
> > On Fri, 2010-06-18 at 09:12 -0700, Jesse Barnes wrote: 
> > > On Fri, 18 Jun 2010 15:06:51 +0300
> > > Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> > > 
> > > > On Wed, 2010-06-09 at 16:05 -0400, Matthew Garrett wrote: 
> > > > > The aspm code will currently set the configured aspm policy before drivers
> > > > > have had an opportunity to indicate that their hardware doesn't support it.
> > > > > Unfortunately, putting some hardware in L0 or L1 can result in the hardware
> > > > > no longer responding to any requests, even after aspm is disabled. It makes
> > > > > more sense to leave aspm policy at the BIOS defaults at initial setup time,
> > > > > reconfiguring it after pci_enable_device() is called. This allows the
> > > > > driver to blacklist individual devices beforehand.
> > > > > 
> > > > > Signed-off-by: Matthew Garrett <mjg@redhat.com>
> > > > > ---
> > > > 
> > > > Hi,
> > > > 
> > > > I recently discovered that my aspire one wireless troubles (card just
> > > > dies after a while) are caused by ASPM L0S state.
> > > > The device (AR5001) seems to have a hardware bug, and it also disables
> > > > L0S in windows driver.
> > > > 
> > > > Unfortenuly BIOS (news at 11) enables L0S.
> > > > 
> > > > Its easy to disable ASPM from driver. It just a matter of calling
> > > > pci_disable_link_state.
> > > > 
> > > > However, that depends on CONFIG_PCIEASPM.
> > > > 
> > > > How about making pci_disable_link_state always available or even better,
> > > > just make CONFIG_PCIEASPM unconditional?
> > > 
> > > The former is ok with me.  Care to post a patch?
> > It not that simple at first glance.
> > This functions uses plenty of code from the aspm.c, therefore care
> > should be taken to do that properly.
> > 
> > Of course the easy solution is to compile all code in always, and just
> > disable it by runtime switch (it even exists, aspm_disabled)
> > Or, another easy solution is to make ath5k depend on CONFIG_PCIEASPM
> > 
> > What do you think?
> 
> So unless a device is *really* broken, it seems like the default policy
> should be ok across the board.  So let's get a CONFIG_PCIEASPM removal
> patch into the 2.6.36 merge window early to flush out any potential
> problems.
It would be perfect for me.

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/