Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 18 Jun 2002 00:15:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 18 Jun 2002 00:15:58 -0400 Received: from garrincha.netbank.com.br ([200.203.199.88]:19462 "HELO garrincha.netbank.com.br") by vger.kernel.org with SMTP id ; Tue, 18 Jun 2002 00:15:58 -0400 Date: Tue, 18 Jun 2002 01:15:39 -0300 From: Arnaldo Carvalho de Melo To: "David S. Miller" , critson@perlfu.co.uk, torvalds@transmeta.com, linux-kernel@vger.kernel.org, netdev@oss.sgi.com Subject: Re: [BKPATCH] Re: [PATCH][2.5.22] OOPS in tcp_v6_get_port Message-ID: <20020618041539.GB18759@conectiva.com.br> Mail-Followup-To: Arnaldo Carvalho de Melo , "David S. Miller" , critson@perlfu.co.uk, torvalds@transmeta.com, linux-kernel@vger.kernel.org, netdev@oss.sgi.com References: <20020617.143319.54623892.davem@redhat.com> <20020618005735.GB1146@conectiva.com.br> <20020617.191726.55300824.davem@redhat.com> <20020618024934.GA4274@conectiva.com.br> <20020618035804.GA18759@conectiva.com.br> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020618035804.GA18759@conectiva.com.br> User-Agent: Mutt/1.4i X-Url: http://advogato.org/person/acme Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1415 Lines: 34 Em Tue, Jun 18, 2002 at 12:58:04AM -0300, Arnaldo C. Melo escreveu: > Em Mon, Jun 17, 2002 at 11:49:34PM -0300, Arnaldo C. Melo escreveu: > > Em Mon, Jun 17, 2002 at 07:17:26PM -0700, David S. Miller escreveu: > > > From: Arnaldo Carvalho de Melo > > > Date: Mon, 17 Jun 2002 21:57:35 -0300 > > > > > > --- orig/net/ipv6/tcp_ipv6.c Sat May 25 23:13:56 2002 > > > +++ linux/net/ipv6/tcp_ipv6.c Fri Jun 14 23:23:07 2002 > > > > > > I've installed this change into my tree in the meantime. > > > If we find a better fix, we can just revert this. > > > > OK, I found a better fix, I think, that allowed me to kill inet6_sk_generic > > in af_inet6.c, using a constructor for the tcpv6, udpv6 and raw6 slab caches, > > as suggested by Russel King, I'll be sending RSN. > > Here it is, David, please consider pulling it from: > > http://kernel-acme.bkbits.net:8080/tcpv6-pinet6 > > Best Regards, > > - Arnaldo Oops, brain fart, David, please don't apply, in tcp_create_openreq_child we overwrite the ->pinet6 field after the constructor inits it to the proper value :( Please leave the old patch in place for a while... :( - Arnaldo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/