Date: Fri, 18 Jun 2010 23:32:51 +0200
From: Samuel Ortiz <sameo@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Mark Brown <broonie@opensource.wolfsonmicro.com>,
       Ian Molton <spyro@f2s.com>, Dmitry Baryshkov <dbaryshkov@gmail.com>
Subject: Re: [PATCH] mfd-core: properly handle
 platform_device_add_resources fail in mfd_add_device
Message-ID: <20100618213250.GG3582@sortiz.org>
References: <1275298255.23779.2.camel@mola>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1275298255.23779.2.camel@mola>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 42

On Mon, May 31, 2010 at 05:30:55PM +0800, Axel Lin wrote:
> platform_device_add_resources may fail, thus add error checking for it.
Thanks Axel, patch applied.

Cheers,
Samuel.

 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  drivers/mfd/mfd-core.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 7dd76bc..1823a57 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -70,7 +70,9 @@ static int mfd_add_device(struct device *parent, int id,
>  			goto fail_res;
>  	}
>  
> -	platform_device_add_resources(pdev, res, cell->num_resources);
> +	ret = platform_device_add_resources(pdev, res, cell->num_resources);
> +	if (ret)
> +		goto fail_res;
>  
>  	ret = platform_device_add(pdev);
>  	if (ret)
> -- 
> 1.5.4.3
> 
> 
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/